From 42fe004c30fe4e893dc741aae4b6d2dccc25e2e7 Mon Sep 17 00:00:00 2001 From: peiy Date: Fri, 19 Jan 2018 15:33:05 +0800 Subject: [PATCH] elif replace if 3 'if' at same levels and each 'if' has 'return', in this case, elif is better than if. more readable, more effective. Change-Id: Ib0528ab69679f320f1580971945ce36eaaedf011 Signed-off-by: peiy --- openstack_dashboard/api/nova.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/openstack_dashboard/api/nova.py b/openstack_dashboard/api/nova.py index c57e2a564b..002aa05fbe 100644 --- a/openstack_dashboard/api/nova.py +++ b/openstack_dashboard/api/nova.py @@ -134,9 +134,9 @@ class Server(base.APIResourceWrapper): if not self.image: return None - if hasattr(self.image, 'name'): + elif hasattr(self.image, 'name'): return self.image.name - if 'name' in self.image: + elif 'name' in self.image: return self.image['name'] else: try: