From f3bd271fc9faba626e5b6f29d8833d4ed0fb74d7 Mon Sep 17 00:00:00 2001 From: Akihiro Motoki Date: Sun, 9 Dec 2018 02:56:33 +0900 Subject: [PATCH] pylint: fix bad-super-call Change-Id: Ia81e5c8b77dbfcb48630b1736d581cdff73278ef --- .pylintrc | 1 - horizon/base.py | 3 ++- openstack_dashboard/dashboards/identity/users/forms.py | 2 +- openstack_dashboard/dashboards/project/images/images/tables.py | 2 +- openstack_dashboard/dashboards/project/snapshots/tables.py | 2 +- openstack_dashboard/dashboards/project/volumes/tables.py | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-) diff --git a/.pylintrc b/.pylintrc index 842e826fc4..1db93c87e0 100644 --- a/.pylintrc +++ b/.pylintrc @@ -12,7 +12,6 @@ disable= # "E" Error for important programming issues (likely bugs) access-member-before-definition, assignment-from-no-return, - bad-super-call, import-error, logging-too-few-args, method-hidden, diff --git a/horizon/base.py b/horizon/base.py index b14652165f..8776f20ddf 100644 --- a/horizon/base.py +++ b/horizon/base.py @@ -1032,7 +1032,8 @@ class HorizonSite(Site): def __new__(cls, *args, **kwargs): if not cls._instance: - cls._instance = super(Site, cls).__new__(cls, *args, **kwargs) + cls._instance = super(HorizonSite, cls).__new__(cls, + *args, **kwargs) return cls._instance diff --git a/openstack_dashboard/dashboards/identity/users/forms.py b/openstack_dashboard/dashboards/identity/users/forms.py index 84507a645f..2e358a18a7 100644 --- a/openstack_dashboard/dashboards/identity/users/forms.py +++ b/openstack_dashboard/dashboards/identity/users/forms.py @@ -50,7 +50,7 @@ class PasswordMixin(forms.SelfHandlingForm): def clean(self): '''Check to make sure password fields match.''' - data = super(forms.Form, self).clean() + data = super(PasswordMixin, self).clean() if 'password' in data and 'confirm_password' in data: if data['password'] != data['confirm_password']: raise ValidationError(_('Passwords do not match.')) diff --git a/openstack_dashboard/dashboards/project/images/images/tables.py b/openstack_dashboard/dashboards/project/images/images/tables.py index 802cadc4fc..983c444bda 100644 --- a/openstack_dashboard/dashboards/project/images/images/tables.py +++ b/openstack_dashboard/dashboards/project/images/images/tables.py @@ -67,7 +67,7 @@ class LaunchImageNG(LaunchImage): def __init__(self, attrs=None, **kwargs): kwargs['preempt'] = True - super(LaunchImage, self).__init__(attrs, **kwargs) + super(LaunchImageNG, self).__init__(attrs, **kwargs) def get_link_url(self, datum): imageId = self.table.get_object_id(datum) diff --git a/openstack_dashboard/dashboards/project/snapshots/tables.py b/openstack_dashboard/dashboards/project/snapshots/tables.py index f0a1e8c1c7..5f9c143562 100644 --- a/openstack_dashboard/dashboards/project/snapshots/tables.py +++ b/openstack_dashboard/dashboards/project/snapshots/tables.py @@ -56,7 +56,7 @@ class LaunchSnapshotNG(LaunchSnapshot): def __init__(self, attrs=None, **kwargs): kwargs['preempt'] = True - super(LaunchSnapshot, self).__init__(attrs, **kwargs) + super(LaunchSnapshotNG, self).__init__(attrs, **kwargs) def get_link_url(self, datum): url = reverse(self.url) diff --git a/openstack_dashboard/dashboards/project/volumes/tables.py b/openstack_dashboard/dashboards/project/volumes/tables.py index 7c7a6b6c37..51dbb513cf 100644 --- a/openstack_dashboard/dashboards/project/volumes/tables.py +++ b/openstack_dashboard/dashboards/project/volumes/tables.py @@ -74,7 +74,7 @@ class LaunchVolumeNG(LaunchVolume): def __init__(self, attrs=None, **kwargs): kwargs['preempt'] = True - super(LaunchVolume, self).__init__(attrs, **kwargs) + super(LaunchVolumeNG, self).__init__(attrs, **kwargs) def get_link_url(self, datum): url = reverse(self.url)