openstack
/
horizon
Code Issues Proposed changes
horizon/openstack_dashboard/dashboards/project/access_and_security/security_groups
History
Suraj Deshmukh 0b4b2976af ICMP type & code validation while adding Security Group rules 
While adding new 'Security Group Rule' viz. 'Custom ICMP rule' when
wrong ICMP 'type' or 'code' was given the errors it would show were
'Not a valid port number'; which is misleading. The errors should
rather be 'Not a valid ICMP type' or 'Not a valid ICMP code'.

Also for validating ICMP 'type' and 'code' there wasn't any dedicated
functionality in 'oslo.utils/netutils' so the code for validating 'TCP
ports' was used. TCP ports are in range 0 to 65535 while ICMP 'type'
and 'code' are in range 0 to 255, so using 'TCP port validation' code
is incorrect.

When -1 is used in 'ICMP code' or 'ICMP type' that means any number
0 to 255 is valid.

Here newer dedicated functionality of 'oslo.utils/netutils' is used
for validating ICMP 'type' and ICMP 'code'.

Change-Id: I8e227a0021d418294fa7b7756d58e39f2100850a
Closes-Bug: #1511748
(cherry picked from commit edfde8b3f5)
 		2016-06-20 15:43:57 +00:00
..
__init__.py Splits OpenStack Dashboard bits from framework app code. 2012-10-11 11:47:50 -07:00
forms.py ICMP type & code validation while adding Security Group rules 2016-06-20 15:43:57 +00:00
tables.py Replace filter() with list-comprehension 2015-10-13 10:39:58 +02:00
tests.py ICMP type & code validation while adding Security Group rules 2016-06-20 15:43:57 +00:00
urls.py Fix E128 errors in openstack_dashboard/dashboards/project/ 2014-10-16 16:53:52 +09:00
views.py Fix TypeError on comparison on Python 3 2015-10-06 16:40:35 +02:00