openstack
/
ironic-inspector-specs
Code Issues Proposed changes

Update patch set 7 

Patch Set 7: Code-Review+2

(1 comment)

Patch-set: 7
Reviewer: Gerrit User 10239 <10239@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=+2
This commit is contained in:
Gerrit User 10239 2018-10-23 08:39:29 +00:00 committed by Gerrit Code Review
parent d71d0c5000
commit 0d34b94e7c
1 changed files with 21 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
524db1e9808a1cc61ced0fa795a8b6e71c22fc3e Normal file
View File

@ -0,0 +1,21 @@
{
"comments": [
{
"key": {
"uuid": "3f79a3b5_2c9ff564",
"filename": "specs/configurable-introspection-data-backends.rst",
"patchSetId": 7
},
"lineNbr": 130,
"author": {
"id": 10239
},
"writtenOn": "2018-10-23T08:39:29Z",
"side": 1,
"message": "do we need it to be that explicit? we are going to provide the configuration file anyway (for credentials), so we can detect the \"to\" part from the current configuration. I\u0027m not sure we can make an informed guess about --from though..",
"revId": "524db1e9808a1cc61ced0fa795a8b6e71c22fc3e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}