Update patch set 4

Patch Set 4:

(2 comments)

Thanks Julia for the review, replies inlined.

Patch-set: 4
Reviewer: Gerrit User 24828 <24828@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Verified=0
This commit is contained in:
Gerrit User 24828 2019-07-04 03:18:23 +00:00 committed by Gerrit Code Review
parent a7fd838550
commit 302fe50277
1 changed files with 48 additions and 0 deletions

View File

@ -23,6 +23,30 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7faddb67_2de68eea",
"filename": "specs/etcd-coordination.rst",
"patchSetId": 4
},
"lineNbr": 57,
"author": {
"id": 24828
},
"writtenOn": "2019-07-04T03:18:23Z",
"side": 1,
"message": "Sorry for not following here, but it sounds like the concept of conductor group if I am guessing right.\nIt could be a further enhancement I guess, we have not considered conductor group though. Our current focus is on the service split, there\u0027s undesired result as the service could only be deployed into a single node, which is not coping well within the same cloud infrastructure.\n\nRecently there is a new requirement due to the lack of etcd service in the cloud, so user don\u0027t want to deploy a new service for inspector and especially from an upgrade. I think it\u0027s still doable with little impact, all we need to do is to implement a db lock mechanism, and utilize messaging queue to load balance rpc requests. I\u0027d like to update the spec to have this proposal if everyone is good with it :)",
"parentUuid": "9fb8cfa7_8db533d3",
"range": {
"startLine": 56,
"startChar": 0,
"endLine": 57,
"endChar": 13
},
"revId": "305d08fa1bbe621ef15866190a147a85d9e5c601",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_4de41be1",
@ -46,6 +70,30 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7faddb67_cdfedaad",
"filename": "specs/etcd-coordination.rst",
"patchSetId": 4
},
"lineNbr": 63,
"author": {
"id": 24828
},
"writtenOn": "2019-07-04T03:18:23Z",
"side": 1,
"message": "Indeed, the configuration option is noted at L147, out of sync with example it appears.",
"parentUuid": "9fb8cfa7_4de41be1",
"range": {
"startLine": 63,
"startChar": 5,
"endLine": 63,
"endChar": 35
},
"revId": "305d08fa1bbe621ef15866190a147a85d9e5c601",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_6d023f72",