openstack
/
ironic-inspector-specs
Code Issues Proposed changes

Update patch set 2 

Patch Set 2: Code-Review+1

(3 comments)

Patch-set: 2
Label: Code-Review=+1
This commit is contained in:
Gerrit User 13636 2017-04-26 15:21:55 +00:00 committed by Gerrit Code Review
parent 2437f0d48e
commit 5f5747a3a5
1 changed files with 54 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

54
a9f03270ce78ea7b09c1784e21a28d2af16db8d5
View File

@ -17,6 +17,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5ff73747_dbabc186",
"filename": "specs/multiple-pxe-filtering-backends.rst",
"patchSetId": 2
},
"lineNbr": 80,
"author": {
"id": 13636
},
"writtenOn": "2017-04-26T15:21:55Z",
"side": 1,
"message": "I guess it would be needed if filter don\u0027t need to update for new nodes, like neutron does",
"parentUuid": "5ff73747_d13f2b23",
"revId": "a9f03270ce78ea7b09c1784e21a28d2af16db8d5",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5ff73747_b13a5f31",
@ -70,6 +88,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5ff73747_9b7779d5",
"filename": "specs/multiple-pxe-filtering-backends.rst",
"patchSetId": 2
},
"lineNbr": 87,
"author": {
"id": 13636
},
"writtenOn": "2017-04-26T15:21:55Z",
"side": 1,
"message": "Why do you need `get_blacklist` and `get_whitelist` as part of the interface?\n\nFilter implements `sync` which could get both lists internally, when does filter clients need both methods?\n\nActually it\u0027s not obvious how to use filter.",
"parentUuid": "5ff73747_2a07f184",
"revId": "a9f03270ce78ea7b09c1784e21a28d2af16db8d5",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5ff73747_9149a3d1",
@ -105,6 +141,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5ff73747_b03ff423",
"filename": "specs/multiple-pxe-filtering-backends.rst",
"patchSetId": 2
},
"lineNbr": 190,
"author": {
"id": 13636
},
"writtenOn": "2017-04-26T15:21:55Z",
"side": 1,
"message": "The idea was to see diff, and discuss inspection and discovery interfaces. Yes, it doesn\u0027t part of this work.",
"parentUuid": "5ff73747_8ac16583",
"revId": "a9f03270ce78ea7b09c1784e21a28d2af16db8d5",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5ff73747_7144d7b7",