Update patch set 2

Patch Set 2:

(3 comments)

Patch-set: 2
Label: Verified=0
This commit is contained in:
Gerrit User 24828 2018-09-26 03:54:10 +00:00 committed by Gerrit Code Review
parent 1db6b46204
commit 8135adb312
1 changed files with 71 additions and 0 deletions

View File

@ -376,6 +376,77 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3f79a3b5_1ff5afcc",
"filename": "specs/configurable-introspection-data-store.rst",
"patchSetId": 2
},
"lineNbr": 30,
"author": {
"id": 24828
},
"writtenOn": "2018-09-26T03:54:10Z",
"side": 1,
"message": "Not sure I get it, but I am feeling you are talking about something like 3rd party plugins. I think we need to satisfy the requirement for upstream version, but other supplements need to address their own requirements. For this spec, there is no additional requirement introduced, maybe it would make things clear by referring to the code?\n\nhttps://review.openstack.org/#/q/topic:story/1726713+(status:open)+(project:openstack/ironic-inspector)",
"parentUuid": "3f79a3b5_ea4e4f94",
"range": {
"startLine": 29,
"startChar": 45,
"endLine": 30,
"endChar": 45
},
"revId": "1bca730bb11f6e7408dcc95291d3e8b4c52cc9b1",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3f79a3b5_df1737ee",
"filename": "specs/configurable-introspection-data-store.rst",
"patchSetId": 2
},
"lineNbr": 30,
"author": {
"id": 24828
},
"writtenOn": "2018-09-26T03:54:10Z",
"side": 1,
"message": "I\u0027m somewhat confused now, maybe the word plugin is broad, there are inspector plugins and stevedore extensions here, do we call stevedore extension as plugin too?",
"parentUuid": "3f79a3b5_61cc9d33",
"range": {
"startLine": 29,
"startChar": 45,
"endLine": 30,
"endChar": 45
},
"revId": "1bca730bb11f6e7408dcc95291d3e8b4c52cc9b1",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3f79a3b5_7fdce344",
"filename": "specs/configurable-introspection-data-store.rst",
"patchSetId": 2
},
"lineNbr": 40,
"author": {
"id": 24828
},
"writtenOn": "2018-09-26T03:54:10Z",
"side": 1,
"message": "Maybe this is the word caused confusion? I guess I should change it to extensions.",
"range": {
"startLine": 40,
"startChar": 44,
"endLine": 40,
"endChar": 51
},
"revId": "1bca730bb11f6e7408dcc95291d3e8b4c52cc9b1",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3f79a3b5_f7eae19d",