Update patch set 2

Patch Set 2:

(7 comments)

thanks Kaifeng, I like the idea, I left few comments inline :)

Patch-set: 2

2a157e26300be615e8e81fb98774d50a27295afd

@@ -0,0 +1,165 @@
+{
+  "comments": [
+    {
+      "key": {
+        "uuid": "3fce034c_7d84ee5e",
+        "filename": "specs/etcd-coordination.rst",
+        "patchSetId": 2
+      },
+      "lineNbr": 26,
+      "author": {
+        "id": 23851
+      },
+      "writtenOn": "2019-04-16T08:17:48Z",
+      "side": 1,
+      "message": "nit: maybe rewrite this as there\u0027s a repetition between beginning and end of the phrase",
+      "range": {
+        "startLine": 24,
+        "startChar": 0,
+        "endLine": 26,
+        "endChar": 11
+      },
+      "revId": "2a157e26300be615e8e81fb98774d50a27295afd",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "3fce034c_bdc9f678",
+        "filename": "specs/etcd-coordination.rst",
+        "patchSetId": 2
+      },
+      "lineNbr": 40,
+      "author": {
+        "id": 23851
+      },
+      "writtenOn": "2019-04-16T08:17:48Z",
+      "side": 1,
+      "message": "would add a short introduction sentence about etcd",
+      "range": {
+        "startLine": 40,
+        "startChar": 3,
+        "endLine": 40,
+        "endChar": 7
+      },
+      "revId": "2a157e26300be615e8e81fb98774d50a27295afd",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "3fce034c_bd6d7699",
+        "filename": "specs/etcd-coordination.rst",
+        "patchSetId": 2
+      },
+      "lineNbr": 53,
+      "author": {
+        "id": 23851
+      },
+      "writtenOn": "2019-04-16T08:17:48Z",
+      "side": 1,
+      "message": "nit: remove one \"query\" word",
+      "range": {
+        "startLine": 53,
+        "startChar": 3,
+        "endLine": 53,
+        "endChar": 14
+      },
+      "revId": "2a157e26300be615e8e81fb98774d50a27295afd",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "3fce034c_bdf016cb",
+        "filename": "specs/etcd-coordination.rst",
+        "patchSetId": 2
+      },
+      "lineNbr": 59,
+      "author": {
+        "id": 23851
+      },
+      "writtenOn": "2019-04-16T08:17:48Z",
+      "side": 1,
+      "message": "same group as API ?",
+      "range": {
+        "startLine": 59,
+        "startChar": 15,
+        "endLine": 59,
+        "endChar": 45
+      },
+      "revId": "2a157e26300be615e8e81fb98774d50a27295afd",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "3fce034c_3ddd0642",
+        "filename": "specs/etcd-coordination.rst",
+        "patchSetId": 2
+      },
+      "lineNbr": 70,
+      "author": {
+        "id": 23851
+      },
+      "writtenOn": "2019-04-16T08:17:48Z",
+      "side": 1,
+      "message": "nit: remove one \"the\" word",
+      "range": {
+        "startLine": 70,
+        "startChar": 52,
+        "endLine": 70,
+        "endChar": 59
+      },
+      "revId": "2a157e26300be615e8e81fb98774d50a27295afd",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "3fce034c_9da43abb",
+        "filename": "specs/etcd-coordination.rst",
+        "patchSetId": 2
+      },
+      "lineNbr": 114,
+      "author": {
+        "id": 23851
+      },
+      "writtenOn": "2019-04-16T08:17:48Z",
+      "side": 1,
+      "message": "s/options below/the following options",
+      "range": {
+        "startLine": 114,
+        "startChar": 42,
+        "endLine": 114,
+        "endChar": 55
+      },
+      "revId": "2a157e26300be615e8e81fb98774d50a27295afd",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "3fce034c_7d8f0e23",
+        "filename": "specs/etcd-coordination.rst",
+        "patchSetId": 2
+      },
+      "lineNbr": 139,
+      "author": {
+        "id": 23851
+      },
+      "writtenOn": "2019-04-16T08:17:48Z",
+      "side": 1,
+      "message": "The idea in general is great, I\u0027m just not sure forcing etcd as mandatory requirement to deploy inspector is; do you think it would be possible to make this optional ?",
+      "range": {
+        "startLine": 139,
+        "startChar": 32,
+        "endLine": 139,
+        "endChar": 71
+      },
+      "revId": "2a157e26300be615e8e81fb98774d50a27295afd",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    }
+  ]
+}