openstack
/
ironic-inspector-specs
Code Issues Proposed changes

Update patch set 10 

Patch Set 10: Code-Review+2

(3 comments)

Hey Anton!

Thanks for the update, I've got just nits, cool w/ follow up.
LGTM

--
milan

Patch-set: 10
Reviewer: Gerrit User 18653 <18653@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=+2
This commit is contained in:
Gerrit User 18653 2017-04-27 15:24:06 +00:00 committed by Gerrit Code Review
parent cfbe29457e
commit d6e5c129b6
1 changed files with 73 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

73
cf953cade17758160bf0be415254f8e0a03676ac Normal file
View File

@ -0,0 +1,73 @@
{
"comments": [
{
"key": {
"uuid": "5ff73747_53c9b123",
"filename": "specs/splitting-service-on-API-and-worker.rst",
"patchSetId": 10
},
"lineNbr": 100,
"author": {
"id": 18653
},
"writtenOn": "2017-04-27T15:24:06Z",
"side": 1,
"message": "nit-ish: \u003cnode_id\u003e",
"range": {
"startLine": 100,
"startChar": 28,
"endLine": 100,
"endChar": 32
},
"revId": "cf953cade17758160bf0be415254f8e0a03676ac",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5ff73747_73294d99",
"filename": "specs/splitting-service-on-API-and-worker.rst",
"patchSetId": 10
},
"lineNbr": 278,
"author": {
"id": 18653
},
"writtenOn": "2017-04-27T15:24:06Z",
"side": 1,
"message": "nit: with an",
"range": {
"startLine": 278,
"startChar": 36,
"endLine": 278,
"endChar": 41
},
"revId": "cf953cade17758160bf0be415254f8e0a03676ac",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5ff73747_d30f0135",
"filename": "specs/splitting-service-on-API-and-worker.rst",
"patchSetId": 10
},
"lineNbr": 295,
"author": {
"id": 18653
},
"writtenOn": "2017-04-27T15:24:06Z",
"side": 1,
"message": "Unsure what this means; or not needed?",
"range": {
"startLine": 295,
"startChar": 0,
"endLine": 295,
"endChar": 32
},
"revId": "cf953cade17758160bf0be415254f8e0a03676ac",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}