Update patch set 2

Patch Set 2: Code-Review-1

(6 comments)

Thanks Ilya, looks really useful

I have few questions.

Patch-set: 2
Reviewer: Gerrit User 13636 <13636@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1

5040e7e662b8abe928d00b7e783130ac205950e2

@@ -0,0 +1,130 @@
+{
+  "comments": [
+    {
+      "key": {
+        "uuid": "5f2577a7_7909972a",
+        "filename": "specs/inspector-error-enumeration.rst",
+        "patchSetId": 2
+      },
+      "lineNbr": 43,
+      "author": {
+        "id": 13636
+      },
+      "writtenOn": "2017-09-12T17:04:59Z",
+      "side": 1,
+      "message": "why do you highlight `Ramdisk Callback API` from REST API? What are trying to say?",
+      "range": {
+        "startLine": 42,
+        "startChar": 0,
+        "endLine": 43,
+        "endChar": 43
+      },
+      "revId": "5040e7e662b8abe928d00b7e783130ac205950e2",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "5f2577a7_b9281f86",
+        "filename": "specs/inspector-error-enumeration.rst",
+        "patchSetId": 2
+      },
+      "lineNbr": 51,
+      "author": {
+        "id": 13636
+      },
+      "writtenOn": "2017-09-12T17:04:59Z",
+      "side": 1,
+      "message": "which? Are you going to create new one?",
+      "range": {
+        "startLine": 51,
+        "startChar": 10,
+        "endLine": 51,
+        "endChar": 16
+      },
+      "revId": "5040e7e662b8abe928d00b7e783130ac205950e2",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "5f2577a7_999e83b6",
+        "filename": "specs/inspector-error-enumeration.rst",
+        "patchSetId": 2
+      },
+      "lineNbr": 69,
+      "author": {
+        "id": 13636
+      },
+      "writtenOn": "2017-09-12T17:04:59Z",
+      "side": 1,
+      "message": "I guess it would be node object, please specify this",
+      "range": {
+        "startLine": 69,
+        "startChar": 25,
+        "endLine": 69,
+        "endChar": 40
+      },
+      "revId": "5040e7e662b8abe928d00b7e783130ac205950e2",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "5f2577a7_f991079b",
+        "filename": "specs/inspector-error-enumeration.rst",
+        "patchSetId": 2
+      },
+      "lineNbr": 72,
+      "author": {
+        "id": 13636
+      },
+      "writtenOn": "2017-09-12T17:04:59Z",
+      "side": 1,
+      "message": "Again, how do they differ?",
+      "range": {
+        "startLine": 72,
+        "startChar": 25,
+        "endLine": 72,
+        "endChar": 54
+      },
+      "revId": "5040e7e662b8abe928d00b7e783130ac205950e2",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "5f2577a7_5986dbdd",
+        "filename": "specs/inspector-error-enumeration.rst",
+        "patchSetId": 2
+      },
+      "lineNbr": 78,
+      "author": {
+        "id": 13636
+      },
+      "writtenOn": "2017-09-12T17:04:59Z",
+      "side": 1,
+      "message": "It would be nice to see initial codes at least? How are you going to enumerate errors? It would be like counter 0,1,2, ...?",
+      "revId": "5040e7e662b8abe928d00b7e783130ac205950e2",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "5f2577a7_b9d37f38",
+        "filename": "specs/inspector-error-enumeration.rst",
+        "patchSetId": 2
+      },
+      "lineNbr": 115,
+      "author": {
+        "id": 13636
+      },
+      "writtenOn": "2017-09-12T17:04:59Z",
+      "side": 1,
+      "message": "you would also need to bump microversion",
+      "revId": "5040e7e662b8abe928d00b7e783130ac205950e2",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    }
+  ]
+}