diff --git a/ansible/group_vars/all/compute b/ansible/group_vars/all/compute index 3d780bb78..273aabc46 100644 --- a/ansible/group_vars/all/compute +++ b/ansible/group_vars/all/compute @@ -75,7 +75,7 @@ compute_lvm_groups_extra: [] # format. compute_lvm_group_data: vgname: data - disks: "{{ compute_lvm_group_data_disks | join(',') }}" + disks: "{{ compute_lvm_group_data_disks }}" create: True lvnames: "{{ compute_lvm_group_data_lvs }}" diff --git a/ansible/group_vars/all/controllers b/ansible/group_vars/all/controllers index bc3812d15..96137b045 100644 --- a/ansible/group_vars/all/controllers +++ b/ansible/group_vars/all/controllers @@ -86,7 +86,7 @@ controller_lvm_groups_extra: [] # format. controller_lvm_group_data: vgname: data - disks: "{{ controller_lvm_group_data_disks | join(',') }}" + disks: "{{ controller_lvm_group_data_disks }}" create: True lvnames: "{{ controller_lvm_group_data_lvs }}" diff --git a/ansible/group_vars/all/seed b/ansible/group_vars/all/seed index cc59a73a7..ab10dd71c 100644 --- a/ansible/group_vars/all/seed +++ b/ansible/group_vars/all/seed @@ -41,7 +41,7 @@ seed_lvm_groups_extra: [] # Seed LVM volume group for data. See mrlesmithjr.manage-lvm role for format. seed_lvm_group_data: vgname: data - disks: "{{ seed_lvm_group_data_disks | join(',') }}" + disks: "{{ seed_lvm_group_data_disks }}" create: True lvnames: "{{ seed_lvm_group_data_lvs }}" diff --git a/ansible/group_vars/all/storage b/ansible/group_vars/all/storage index 94317397b..c1dce7668 100644 --- a/ansible/group_vars/all/storage +++ b/ansible/group_vars/all/storage @@ -74,7 +74,7 @@ storage_lvm_groups_extra: [] # format. storage_lvm_group_data: vgname: data - disks: "{{ storage_lvm_group_data_disks | join(',') }}" + disks: "{{ storage_lvm_group_data_disks }}" create: True lvnames: "{{ storage_lvm_group_data_lvs }}" diff --git a/ansible/lvm.yml b/ansible/lvm.yml index 6ee61b538..a85c69e71 100644 --- a/ansible/lvm.yml +++ b/ansible/lvm.yml @@ -3,6 +3,7 @@ hosts: seed:overcloud tags: - lvm + - upgrade-check pre_tasks: - name: Fail if the LVM physical disks have not been configured fail: @@ -12,6 +13,14 @@ has a valid 'disks' list. with_items: "{{ lvm_groups | default([]) }}" when: not item.disks | default([]) or 'changeme' in item.disks | default([]) + - name: Fail if the LVM physical disks are configured as a comma-separated string + fail: + msg: > + The physical disk list for volume {{ item.vgname }} must be + configured as a list instead of a comma-separated string. Ensure that + each volume group in 'lvm_groups' has a valid 'disks' list. + with_items: "{{ lvm_groups | default([]) }}" + when: item.disks | string() == item.disks roles: - role: mrlesmithjr.manage-lvm manage_lvm: True diff --git a/releasenotes/notes/manage-lvm-0.1.4-d33b398060232874.yaml b/releasenotes/notes/manage-lvm-0.1.4-d33b398060232874.yaml new file mode 100644 index 000000000..c43229972 --- /dev/null +++ b/releasenotes/notes/manage-lvm-0.1.4-d33b398060232874.yaml @@ -0,0 +1,13 @@ +--- +upgrade: + - | + The manage-lvm Ansible role was upgraded to version v0.1.4. If you are + overriding variables to customize definitions of volume groups, you need to + change the value of the ``disks`` parameter from a comma-separated string to a + list. For example, change ``disks: "/dev/sda,/dev/sdb"`` to: + + .. code-block:: text + + disks: + - "/dev/sda" + - "/dev/sdb" diff --git a/requirements.yml b/requirements.yml index 125d9b4d9..662d3cdbd 100644 --- a/requirements.yml +++ b/requirements.yml @@ -7,7 +7,7 @@ - src: MichaelRigart.interfaces version: v1.1.0 - src: mrlesmithjr.manage-lvm - version: v0.1.1 + version: v0.1.4 - src: resmo.ntp version: 0.4.0 - src: singleplatform-eng.users