openstack
/
kayobe
Code Issues Proposed changes

Update patch set 30 

Patch Set 30:

(2 comments)

Patch-set: 30
This commit is contained in:
Gerrit User 36238 2024-05-03 10:32:31 +00:00 committed by Gerrit Code Review
parent 2a4cd101b0
commit f82e7053f9
1 changed files with 36 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
9402278b82726b7e67e47b23cbbd037109200af4
View File

@ -17,6 +17,24 @@
"revId": "9402278b82726b7e67e47b23cbbd037109200af4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "fb84c291_8f9277b5",
"filename": "ansible/baremetal-compute-register.yml",
"patchSetId": 28
},
"lineNbr": 31,
"author": {
"id": 36238
},
"writtenOn": "2024-05-03T10:32:31Z",
"side": 1,
"message": "Done",
"parentUuid": "cc492f8a_3c174e16",
"revId": "9402278b82726b7e67e47b23cbbd037109200af4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -50,6 +68,24 @@
"message": "These variables don\u0027t have defaults, so are liable to explode if undefined. It would be sensible to have an assert task before this one to check anything that doesn\u0027t have a default.\n\ne.g. assert that X is defined",
"revId": "9402278b82726b7e67e47b23cbbd037109200af4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "604a969e_1962daa0",
"filename": "ansible/baremetal-compute-register.yml",
"patchSetId": 28
},
"lineNbr": 54,
"author": {
"id": 36238
},
"writtenOn": "2024-05-03T10:32:31Z",
"side": 1,
"message": "Added an assert task",
"parentUuid": "43acfa5f_64f971f4",
"revId": "9402278b82726b7e67e47b23cbbd037109200af4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}