openstack
/
keystone-specs
Code Issues Proposed changes

Update patch set 14 

Patch Set 14:

(3 comments)

Patch-set: 14
Attention: {"person_ident":"Gerrit User 27900 \u003c27900@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_28356\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 28356 \u003c28356@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_28356\u003e replied on the change"}
This commit is contained in:
Gerrit User 28356 2024-04-09 19:25:32 +00:00 committed by Gerrit Code Review
parent 8222de0bcf
commit 04b7fcc467
1 changed files with 54 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

54
60ab8d5331b4d275664c810b72aad972a9dda576
View File

@ -17,6 +17,24 @@
"revId": "60ab8d5331b4d275664c810b72aad972a9dda576",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "8ab39215_e781b39e",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 14
},
"lineNbr": 0,
"author": {
"id": 28356
},
"writtenOn": "2024-04-09T19:25:32Z",
"side": 1,
"message": "I responded to your suggestions, and I did the changes that are necessary only.",
"parentUuid": "f8261293_0dbea575",
"revId": "60ab8d5331b4d275664c810b72aad972a9dda576",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -70,6 +88,24 @@
"revId": "60ab8d5331b4d275664c810b72aad972a9dda576",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "82914e19_d3207b74",
"filename": "specs/keystone/2024.1/federated-identity-mapping-support-project-json-definition.rst",
"patchSetId": 14
},
"lineNbr": 137,
"author": {
"id": 28356
},
"writtenOn": "2024-04-09T19:25:32Z",
"side": 1,
"message": "I sincerely do not see the problem. This is just an example, and should be taken as such. We do not need to follow it\n\nI added a note to stress that before the example of configuration is shown.",
"parentUuid": "ad356ee2_4e078b00",
"revId": "60ab8d5331b4d275664c810b72aad972a9dda576",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -122,6 +158,24 @@
"parentUuid": "0afd273a_49532ada",
"revId": "60ab8d5331b4d275664c810b72aad972a9dda576",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "6f208228_f30e2ac9",
"filename": "specs/keystone/2024.1/federated-identity-mapping-support-project-json-definition.rst",
"patchSetId": 14
},
"lineNbr": 140,
"author": {
"id": 28356
},
"writtenOn": "2024-04-09T19:25:32Z",
"side": 1,
"message": "If we do that, it would not be possible to use both options together. In my current implementation, the hard coded project definition is enriched with the projects that come from the project_json variable. Therefore, I would prefer to maintain such compatibility.",
"parentUuid": "605023b0_734ed84c",
"revId": "60ab8d5331b4d275664c810b72aad972a9dda576",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}