openstack
/
keystone-specs
Code Issues Proposed changes

Update patch set 3 

Patch Set 3: Code-Review+1

(4 comments)

Patch-set: 3
Reviewer: Gerrit User 7973 <7973@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=+1, 46ade04df9b6c3eddb6b7f8617118ce17c53e36f
Attention: {"person_ident":"Gerrit User 7973 \u003c7973@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_7973\u003e replied on the change"}
This commit is contained in:
Gerrit User 7973 2024-04-26 15:21:52 +00:00 committed by Gerrit Code Review
parent 013836701a
commit 298735dc8a
1 changed files with 90 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

90
f949b99d6bb9799137fa377136691b8f72538d11 Normal file
View File

@ -0,0 +1,90 @@
{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "1bc0c42f_a11aac1c",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 3
},
"lineNbr": 0,
"author": {
"id": 7973
},
"writtenOn": "2024-04-26T15:21:52Z",
"side": 1,
"message": "In general I like the direction of this. It will be great when we can replace api-ref with openapi. I just have a couple of minor comments before I +2 this.",
"revId": "f949b99d6bb9799137fa377136691b8f72538d11",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "41efd459_add12789",
"filename": "specs/keystone/2024.2/openapi.rst",
"patchSetId": 3
},
"lineNbr": 50,
"author": {
"id": 7973
},
"writtenOn": "2024-04-26T15:21:52Z",
"side": 1,
"message": "This doesn\u0027t seem relevant. Keystone\u0027s API docs are available online https://docs.openstack.org/api-ref/identity/ and can be built locally with `tox -e docs`. You don\u0027t need a running Nova instance to use either option.",
"range": {
"startLine": 49,
"startChar": 0,
"endLine": 50,
"endChar": 64
},
"revId": "f949b99d6bb9799137fa377136691b8f72538d11",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "c0d2e4be_16ec584a",
"filename": "specs/keystone/2024.2/openapi.rst",
"patchSetId": 3
},
"lineNbr": 54,
"author": {
"id": 7973
},
"writtenOn": "2024-04-26T15:21:52Z",
"side": 1,
"message": "s/Nova/Keystone?",
"range": {
"startLine": 54,
"startChar": 5,
"endLine": 54,
"endChar": 9
},
"revId": "f949b99d6bb9799137fa377136691b8f72538d11",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "efeb77a5_c91a675f",
"filename": "specs/keystone/2024.2/openapi.rst",
"patchSetId": 3
},
"lineNbr": 89,
"author": {
"id": 7973
},
"writtenOn": "2024-04-26T15:21:52Z",
"side": 1,
"message": "s/Nova/Keystone",
"range": {
"startLine": 89,
"startChar": 23,
"endLine": 89,
"endChar": 27
},
"revId": "f949b99d6bb9799137fa377136691b8f72538d11",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}