openstack
/
keystone-specs
Code Issues Proposed changes

Update patch set 14 

Patch Set 14: -Code-Review

(2 comments)

Patch-set: 14
Label: Code-Review=0, c7e4f61a8d3cbea509c7853146c39ab06d76a662
This commit is contained in:
Gerrit User 27900 2024-02-28 18:40:14 +00:00 committed by Gerrit Code Review
parent bce8724708
commit a4bc61a3d6
1 changed files with 38 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
60ab8d5331b4d275664c810b72aad972a9dda576 Normal file
View File

@ -0,0 +1,38 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "d53002b1_fd0fb467",
"filename": "specs/keystone/2024.1/federated-identity-mapping-support-project-json-definition.rst",
"patchSetId": 14
},
"lineNbr": 137,
"author": {
"id": 27900
},
"writtenOn": "2024-02-28T18:40:14Z",
"side": 1,
"message": "I actually suggest to drop this here. User domain is already specified few lines above and works as expected. Specifying it 2 times confuses users (admins) about how to configure it properly.\nI honestly think it was a failure to introduce it previously since domain is an attribute of the user and project (literally everywhere)",
"revId": "60ab8d5331b4d275664c810b72aad972a9dda576",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "ec2db8f8_90620d33",
"filename": "specs/keystone/2024.1/federated-identity-mapping-support-project-json-definition.rst",
"patchSetId": 14
},
"lineNbr": 140,
"author": {
"id": 27900
},
"writtenOn": "2024-02-28T18:40:14Z",
"side": 1,
"message": "can\u0027t we reuse existing project mapping so that it is always an object which is either defined explicitly or come from idp?",
"revId": "60ab8d5331b4d275664c810b72aad972a9dda576",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}