openstack
/
keystone-specs
Code Issues Proposed changes

Update patch set 9 

Patch Set 9:

(2 comments)

Patch-set: 9
Attention: {"person_ident":"Gerrit User 7973 \u003c7973@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_8556\u003e replied on the change"}
This commit is contained in:
Gerrit User 8556 2024-04-19 17:17:21 +00:00 committed by Gerrit Code Review
parent 9f61a3333f
commit c87d538547
1 changed files with 48 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

48
48e33cd5b79b89f7a64d21def0c0a436ae3fb992
View File

@ -74,6 +74,30 @@
"revId": "48e33cd5b79b89f7a64d21def0c0a436ae3fb992",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "21da2f27_5f925565",
"filename": "specs/keystone/2024.1/domain-manager-persona.rst",
"patchSetId": 9
},
"lineNbr": 64,
"author": {
"id": 8556
},
"writtenOn": "2024-04-19T17:17:21Z",
"side": 1,
"message": "++",
"parentUuid": "074053ff_86e22ab9",
"range": {
"startLine": 64,
"startChar": 19,
"endLine": 64,
"endChar": 31
},
"revId": "48e33cd5b79b89f7a64d21def0c0a436ae3fb992",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -119,6 +143,30 @@
},
"revId": "48e33cd5b79b89f7a64d21def0c0a436ae3fb992",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "3f1f7855_90d8a387",
"filename": "specs/keystone/2024.1/domain-manager-persona.rst",
"patchSetId": 9
},
"lineNbr": 118,
"author": {
"id": 8556
},
"writtenOn": "2024-04-19T17:17:21Z",
"side": 1,
"message": "We should avoid using the negative regex in check_str which can allow many other roles also which we do not want. For example, with \u0027not admin\u0027 it will allow role foo to access the API.\n\nMentioning all the allowed roles will restrict the access in correct way.",
"parentUuid": "e9529a6e_fd00b653",
"range": {
"startLine": 116,
"startChar": 18,
"endLine": 118,
"endChar": 47
},
"revId": "48e33cd5b79b89f7a64d21def0c0a436ae3fb992",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}