openstack
/
keystone-specs
Code Issues Proposed changes

Update patch set 11 

Patch Set 11: Code-Review-1

(1 comment)

Patch-set: 11
Reviewer: Gerrit User 27900 <27900@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1, cb0f3e1ba9bcdc44d34b51e050fef8e75e233d79
Attention: {"person_ident":"Gerrit User 28356 \u003c28356@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_27900\u003e replied on the change"}
This commit is contained in:
Gerrit User 27900 2024-01-29 08:22:48 +00:00 committed by Gerrit Code Review
parent 3e6313d6f3
commit cd9ea6f41a
1 changed files with 21 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
90ffbc6081dee41196fcda7be249c02c9f0364ea Normal file
View File

@ -0,0 +1,21 @@
{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "4a1cc2cf_e50b75d3",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 11
},
"lineNbr": 0,
"author": {
"id": 27900
},
"writtenOn": "2024-01-29T08:22:48Z",
"side": 1,
"message": "I am generally absolutely supporting such step, but miss few things to be explicit here:\n\n- should the mapping be persisted when user logs in or the information stays dynamic only in the token? Keeping it dynamic would have in my eyes potential for issues with services and for users it would be absolutely in transparent (who in the domain is currently having which roles/projects)\n\n- If changes are persisted upon user log in - what happens when the definition changes (projects/roles removed). Are \"old\" values purged or only new changes are added? AFAIK current behavior is to keep old data and apply new (what is bad). If we are about to add more dynamics, shouldn\u0027t we add also possibility to specify whether new mapping should be simply applied or \"replace\" the current one? I guess this possibility would be actively used by many.",
"revId": "90ffbc6081dee41196fcda7be249c02c9f0364ea",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}