Update patch set 13

Patch Set 13: Code-Review+1

(2 comments)

Patch-set: 13
Reviewer: Gerrit User 30695 <30695@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=+1, 2473653ddc54d7fb9cbac73696fb24d2d8544779
Attention: {"person_ident":"Gerrit User 28356 \u003c28356@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_30695\u003e replied on the change"}
This commit is contained in:
Gerrit User 30695 2024-02-28 17:40:58 +00:00 committed by Gerrit Code Review
parent cc4d594e5a
commit dfbd1f17ee
1 changed files with 40 additions and 0 deletions

View File

@ -68,6 +68,46 @@
"message": "Thanks David!\n\nAs soon as this one is merged, I will update the patchset for this spec.",
"revId": "d44747e2d457f9405e177f1bddfdae5ddc0bd2cf",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "b161c6ae_dd413581",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 13
},
"lineNbr": 0,
"author": {
"id": 30695
},
"writtenOn": "2024-02-28T17:40:58Z",
"side": 1,
"message": "Nice spec, it will help to enhance the project\u0027s users assignments management in environments with federated authentication. I have only a nit suggestion, but nothing so important, then I am leaving my +1.\nThanks for the spec.",
"revId": "d44747e2d457f9405e177f1bddfdae5ddc0bd2cf",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "fc92ebc9_0e225928",
"filename": "specs/keystone/2024.1/federated-identity-mapping-support-project-json-definition.rst",
"patchSetId": 13
},
"lineNbr": 16,
"author": {
"id": 30695
},
"writtenOn": "2024-02-28T17:40:58Z",
"side": 1,
"message": "IdP or Identity Provider, guess IdP provider is redundant",
"range": {
"startLine": 16,
"startChar": 35,
"endLine": 16,
"endChar": 43
},
"revId": "d44747e2d457f9405e177f1bddfdae5ddc0bd2cf",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}