154 lines
5.0 KiB
Plaintext
154 lines
5.0 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "0aea7124_b88b9fc3",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 13
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 27900
|
|
},
|
|
"writtenOn": "2024-01-31T09:54:12Z",
|
|
"side": 1,
|
|
"message": "I am pretty sure there would be other reviews requiring changes, I just show my support with +1.\n\nbtw, looking at the release cycle I am sadly not sure it is possible to get anything new into 2024.1. If Keystone cores are ok keeping the spec tied to that release while the implementation will most likely land only for next release (as a new feature) I would keep it this way",
|
|
"revId": "d44747e2d457f9405e177f1bddfdae5ddc0bd2cf",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "05de247f_aaf6666b",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 13
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 28356
|
|
},
|
|
"writtenOn": "2024-01-31T10:11:15Z",
|
|
"side": 1,
|
|
"message": "Thanks for your support and valuable reviews! If it does not go out on 2024.1, it is not a problem.However, as soon as this one is merged, and we have a picture on the feature to be updated in the patch that we already have, I will update it as soon as possible.",
|
|
"parentUuid": "0aea7124_b88b9fc3",
|
|
"revId": "d44747e2d457f9405e177f1bddfdae5ddc0bd2cf",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "3165f5d1_a00946e1",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 13
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 28356
|
|
},
|
|
"writtenOn": "2024-02-06T13:28:05Z",
|
|
"side": 1,
|
|
"message": "Hello guys, \nToday we have the Keystone meeting, are we going to discuss this spec in the meeting? If you need any help or adjusts here, just let me know.",
|
|
"revId": "d44747e2d457f9405e177f1bddfdae5ddc0bd2cf",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "212652cf_3d474e34",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 13
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 28356
|
|
},
|
|
"writtenOn": "2024-02-28T16:58:54Z",
|
|
"side": 1,
|
|
"message": "Thanks David!\n\nAs soon as this one is merged, I will update the patchset for this spec.",
|
|
"revId": "d44747e2d457f9405e177f1bddfdae5ddc0bd2cf",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "b161c6ae_dd413581",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 13
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 30695
|
|
},
|
|
"writtenOn": "2024-02-28T17:40:58Z",
|
|
"side": 1,
|
|
"message": "Nice spec, it will help to enhance the project\u0027s users assignments management in environments with federated authentication. I have only a nit suggestion, but nothing so important, then I am leaving my +1.\nThanks for the spec.",
|
|
"revId": "d44747e2d457f9405e177f1bddfdae5ddc0bd2cf",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "31e99f41_71c9574b",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 13
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 28356
|
|
},
|
|
"writtenOn": "2024-02-28T17:44:08Z",
|
|
"side": 1,
|
|
"message": "Thanks Pedro! I amended the spec.",
|
|
"revId": "d44747e2d457f9405e177f1bddfdae5ddc0bd2cf",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "fc92ebc9_0e225928",
|
|
"filename": "specs/keystone/2024.1/federated-identity-mapping-support-project-json-definition.rst",
|
|
"patchSetId": 13
|
|
},
|
|
"lineNbr": 16,
|
|
"author": {
|
|
"id": 30695
|
|
},
|
|
"writtenOn": "2024-02-28T17:40:58Z",
|
|
"side": 1,
|
|
"message": "IdP or Identity Provider, guess IdP provider is redundant",
|
|
"range": {
|
|
"startLine": 16,
|
|
"startChar": 35,
|
|
"endLine": 16,
|
|
"endChar": 43
|
|
},
|
|
"revId": "d44747e2d457f9405e177f1bddfdae5ddc0bd2cf",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "17713872_8f67b692",
|
|
"filename": "specs/keystone/2024.1/federated-identity-mapping-support-project-json-definition.rst",
|
|
"patchSetId": 13
|
|
},
|
|
"lineNbr": 16,
|
|
"author": {
|
|
"id": 28356
|
|
},
|
|
"writtenOn": "2024-02-28T17:44:08Z",
|
|
"side": 1,
|
|
"message": "agree",
|
|
"parentUuid": "fc92ebc9_0e225928",
|
|
"range": {
|
|
"startLine": 16,
|
|
"startChar": 35,
|
|
"endLine": 16,
|
|
"endChar": 43
|
|
},
|
|
"revId": "d44747e2d457f9405e177f1bddfdae5ddc0bd2cf",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
}
|
|
]
|
|
} |