diff --git a/keystone/token/persistence/backends/sql.py b/keystone/token/persistence/backends/sql.py index 982ca31246..06ce57948c 100644 --- a/keystone/token/persistence/backends/sql.py +++ b/keystone/token/persistence/backends/sql.py @@ -276,9 +276,12 @@ class Token(token.persistence.TokenDriverBase): return _expiry_range_all def flush_expired_tokens(self): - with sql.session_for_write() as session: - # Turn off autocommit, as it doesn't work well with batch delete - session.autocommit = False + # The DBAPI itself is in a "never autocommit" mode, + # BEGIN is emitted automatically as soon as any work is done, + # COMMIT is emitted when SQLAlchemy invokes commit() on the + # underlying DBAPI connection. So SQLAlchemy is only simulating + # "begin" here in any case, it is in fact automatic by the DBAPI. + with sql.session_for_write() as session: # Calls session.begin() dialect = session.bind.dialect.name expiry_range_func = self._expiry_range_strategy(dialect) query = session.query(TokenModel.expires) @@ -291,9 +294,14 @@ class Token(token.persistence.TokenDriverBase): # Explicitly commit each batch so as to free up # resources early. We do not actually need # transactional semantics here. - session.commit() + session.commit() # Emits connection.commit() on DBAPI + # Tells SQLAlchemy to "begin", e.g. hold a new connection + # open in a transaction + session.begin() total_removed += row_count LOG.debug('Removed %d total expired tokens', total_removed) + # When the "with: " block ends, the final "session.commit()" + # is emitted by enginefacade session.flush() LOG.info(_LI('Total expired tokens removed: %d'), total_removed) diff --git a/releasenotes/notes/bug-1649616-b835d1dac3401e8c.yaml b/releasenotes/notes/bug-1649616-b835d1dac3401e8c.yaml new file mode 100644 index 0000000000..a7df50b1a0 --- /dev/null +++ b/releasenotes/notes/bug-1649616-b835d1dac3401e8c.yaml @@ -0,0 +1,6 @@ +--- +fixes: + - | + [`bug 1689616 `_] + Significant improvements have been made when performing a token flush + on massive data sets.