From 1c05f5f88d84d90ca949bab6e3d48c5f1e35a909 Mon Sep 17 00:00:00 2001 From: Morgan Fainberg Date: Thu, 11 Oct 2018 13:05:16 -0700 Subject: [PATCH] Make Request Logging a little better Use the flask.request properties instead of direct environ lookups, as this is more representative of what is happening in the application. Change-Id: Ic16c5ea26b2f526b51ef167e6f6977c72df1d06a Partial-Bug: #1776504 --- keystone/server/flask/request_processing/req_logging.py | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/keystone/server/flask/request_processing/req_logging.py b/keystone/server/flask/request_processing/req_logging.py index acae061590..c1c39e3f26 100644 --- a/keystone/server/flask/request_processing/req_logging.py +++ b/keystone/server/flask/request_processing/req_logging.py @@ -18,14 +18,12 @@ from oslo_log import log LOG = log.getLogger(__name__) -_ENVIRON_KEYS = ('SCRIPT_NAME', 'PATH_INFO') def log_request_info(): # Add in any extra debug logging about the request that is desired # note that this is executed prior to routing the request to a resource # so the data is somewhat raw. - for element in _ENVIRON_KEYS: - LOG.debug("environ['%(key)s']: %(value)s", - {'key': element, - 'value': flask.request.environ.get(element, '<>')}) + LOG.debug('REQUEST_METHOD: `%s`', flask.request.method) + LOG.debug('SCRIPT_NAME: `%s`', flask.request.script_root) + LOG.debug('PATH_INFO: `%s`', flask.request.path)