openstack
/
keystone
Code Issues Proposed changes

Raise NotImplementedError instead of NotImplemented 

NotImplementedError is the name of the exception
(https://docs.python.org/2/library/exceptions.html).
NotImplemented is the name of a constant
(https://docs.python.org/2/library/constants.html).
>>> raise NotImplemented()
Traceback (most recent call last):
  File "<pyshell#31>", line 1, in <module>
    raise NotImplemented()
TypeError: 'NotImplementedType' object is not callable
>>> raise NotImplementedError()
Traceback (most recent call last):
  File "<pyshell#32>", line 1, in <module>
    raise NotImplementedError()
NotImplementedError

This patch fix it.

Change-Id: I36292e5ee18bd792205a8ff527f4ae9705c61b61
Closes-Bug: #1339855
This commit is contained in:
Ji-Wei 2016-09-03 13:03:13 +08:00 committed by JiWei
parent 32af31f509
commit 5a49379b34
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
keystone/tests/unit/test_hacking_checks.py
View File

@ -29,7 +29,8 @@ class BaseStyleCheck(unit.BaseTestCase):
def get_checker(self):
"""Return the checker to be used for tests in this class."""
raise NotImplemented('subclasses must provide a real implementation')
raise NotImplementedError('subclasses must provide '
'a real implementation')
def get_fixture(self):
return hacking_fixtures.HackingCode()