From 07a66b9c2e02d5fea92455fb56e26734df49ce8f Mon Sep 17 00:00:00 2001
From: Lance Bragstad <lbragstad@gmail.com>
Date: Wed, 7 Mar 2018 21:24:54 +0000
Subject: [PATCH] Mark the implied role API as stable

This API has been in keystone for a long time and we never updated it
to stable, yet we treat it like a stable API. This change updates the
JSON home document to reflect that. This is also consistent with
discussions during the Rocky PTG:

  https://etherpad.openstack.org/p/keystone-rocky-ptg-json-home

Change-Id: I0b5aef233d9e51799595802d0812015866727987
---
 keystone/assignment/routers.py                            | 3 ---
 keystone/tests/unit/test_versions.py                      | 8 ++++----
 .../notes/implied-roles-stable-8b293e187c5620ad.yaml      | 7 +++++++
 3 files changed, 11 insertions(+), 7 deletions(-)
 create mode 100644 releasenotes/notes/implied-roles-stable-8b293e187c5620ad.yaml

diff --git a/keystone/assignment/routers.py b/keystone/assignment/routers.py
index a97d81f0f8..576260973e 100644
--- a/keystone/assignment/routers.py
+++ b/keystone/assignment/routers.py
@@ -62,7 +62,6 @@ class Routers(wsgi.RoutersBase):
             path='/roles/{prior_role_id}/implies',
             rel=json_home.build_v3_resource_relation('implied_roles'),
             get_head_action='list_implied_roles',
-            status=json_home.Status.EXPERIMENTAL,
             path_vars={
                 'prior_role_id': json_home.Parameters.ROLE_ID,
             }
@@ -76,7 +75,6 @@ class Routers(wsgi.RoutersBase):
             head_action='check_implied_role',
             get_action='get_implied_role',
             rel=json_home.build_v3_resource_relation('implied_role'),
-            status=json_home.Status.EXPERIMENTAL,
             path_vars={
                 'prior_role_id': json_home.Parameters.ROLE_ID,
                 'implied_role_id': json_home.Parameters.ROLE_ID
@@ -87,7 +85,6 @@ class Routers(wsgi.RoutersBase):
             path='/role_inferences',
             get_head_action='list_role_inference_rules',
             rel=json_home.build_v3_resource_relation('role_inferences'),
-            status=json_home.Status.EXPERIMENTAL,
             path_vars={}
         )
 
diff --git a/keystone/tests/unit/test_versions.py b/keystone/tests/unit/test_versions.py
index 731a0121dc..2eae650079 100644
--- a/keystone/tests/unit/test_versions.py
+++ b/keystone/tests/unit/test_versions.py
@@ -365,8 +365,8 @@ V3_JSON_HOME_RESOURCES = {
     json_home.build_v3_resource_relation('implied_roles'): {
         'href-template': '/roles/{prior_role_id}/implies',
         'href-vars': {
-            'prior_role_id': json_home.Parameters.ROLE_ID},
-        'hints': {'status': 'experimental'}},
+            'prior_role_id': json_home.Parameters.ROLE_ID}
+    },
     json_home.build_v3_resource_relation('implied_role'): {
         'href-template':
         '/roles/{prior_role_id}/implies/{implied_role_id}',
@@ -374,10 +374,10 @@ V3_JSON_HOME_RESOURCES = {
             'prior_role_id': json_home.Parameters.ROLE_ID,
             'implied_role_id': json_home.Parameters.ROLE_ID,
         },
-        'hints': {'status': 'experimental'}},
+    },
     json_home.build_v3_resource_relation('role_inferences'): {
         'href': '/role_inferences',
-        'hints': {'status': 'experimental'}},
+    },
     json_home.build_v3_resource_relation('role_assignments'): {
         'href': '/role_assignments'},
     json_home.build_v3_resource_relation('roles'): {'href': '/roles'},
diff --git a/releasenotes/notes/implied-roles-stable-8b293e187c5620ad.yaml b/releasenotes/notes/implied-roles-stable-8b293e187c5620ad.yaml
new file mode 100644
index 0000000000..7c2e2f8aa5
--- /dev/null
+++ b/releasenotes/notes/implied-roles-stable-8b293e187c5620ad.yaml
@@ -0,0 +1,7 @@
+---
+other:
+  - |
+    The `implied roles API <https://developer.openstack.org/api-ref/identity/v3/index.html#roles>`_
+    has been marked as stable. This API was originally implemented in Mitaka
+    and marked as experimental. There haven't been any backwards incompatible
+    updates since then. As a result, the API is being marked as stable.