openstack
/
keystone
Code Issues Proposed changes

Fix federation unit test 

A patch[1] was introduced to demonstrate a bug in federation token
auth[2]. The bug was later fixed[3] but one of the new tests was never
un-WIP'd. It continued to "fail as expected" because it was using a
method that didn't exist, not failing due to the bug it was supposed to
expose. This patch fixes the test and un-WIPs it.

[1] https://review.openstack.org/#/c/229125
[2] https://bugs.launchpad.net/keystone/+bug/1501032
[3] https://review.openstack.org/#/c/431181/

Change-Id: I4d76362256e41fafc87d413cde090fb12450ec83
This commit is contained in:
Colleen Murphy 2018-01-07 14:48:38 +01:00
parent abb0d552a1
commit d69fdd9b5e
1 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
keystone/tests/unit/test_v3_federation.py
View File

@ -2869,9 +2869,6 @@ class FederatedTokenTestsMethodToken(FederatedTokenTests):
super(FederatedTokenTests,
self).auth_plugin_config_override(methods)
@utils.wip('This will fail because of bug #1501032. The returned method'
'list should contain "saml2". This is documented in bug '
'1501032.')
def test_full_workflow(self):
"""Test 'standard' workflow for granting access tokens.
@ -2894,7 +2891,7 @@ class FederatedTokenTestsMethodToken(FederatedTokenTests):
v3_scope_request = self._scope_request(employee_unscoped_token_id,
'project', project['id'])
r = self.v3_authenticate_token(v3_scope_request)
r = self.v3_create_token(v3_scope_request)
token_resp = r.result['token']
self.assertIn('token', token_resp['methods'])
self.assertIn('saml2', token_resp['methods'])