openstack
/
keystoneauth
Code Issues Proposed changes

Fix hacking min version to 3.0.1 

flake8 new release 3.8.0 added new checks and gate pep8
job start failing. hacking 3.0.1 fix the pinning of flake8 to
avoid bringing in a new version with new checks.

Though it is fixed in latest hacking but 2.0 and 3.0 has cap for
flake8 as <4.0.0 which mean flake8 new version 3.9.0 can also
break the pep8 job if new check are added.

Cap pycodestyle also  as flake8-import-order does not cap the pycodestyle
and pull its latest version and break things.

Also removing the pycodestyle from lower-constraints file
as theose are blacklisted requirements and does not need to be present
there.

To avoid similar gate break in future, we need to bump the hacking min
version.

- http://lists.openstack.org/pipermail/openstack-discuss/2020-May/014828.html

Change-Id: I003f8f63e06c5263ef88df9dab90bbd74cb62ea5
This commit is contained in:
Ghanshyam Mann 2020-05-12 18:28:00 -05:00 committed by Monty Taylor
parent 4743b7f8e4
commit fdd4078202
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
lower-constraints.txt
View File

@ -42,7 +42,6 @@ Parsley==1.3
pbr==2.0.0
pep257==0.7.0
prettytable==0.7.2
pycodestyle==2.3.1
Pygments==2.2.0
pyparsing==2.2.0
pyperclip==1.6.0

3
test-requirements.txt
View File

@ -2,9 +2,10 @@
# of appearance. Changing the order has an impact on the overall integration
# process, which may cause wedges in the gate later.
hacking>=3.0,<3.1.0 # Apache-2.0
hacking>=3.0.1,<3.1.0 # Apache-2.0
flake8-docstrings==0.2.1.post1 # MIT
flake8-import-order>=0.17.1 #LGPLv3
pycodestyle>=2.0.0,<2.6.0 # MIT
bandit<1.6.0,>=1.1.0 # Apache-2.0
coverage!=4.4,>=4.0 # Apache-2.0