From d06345716e6331f6047cf9c79ed0da9af0587523 Mon Sep 17 00:00:00 2001 From: Yossi Boaron Date: Wed, 12 Dec 2018 18:11:51 +0200 Subject: [PATCH] Log k8s endpoints being ignored by Kuryr This patch logged the details of endpoints being ignored by Kuryr controller Change-Id: I6bb6b83a038f1fc2c3a6bb5e4c99539063d191f9 --- kuryr_kubernetes/controller/handlers/lbaas.py | 9 ++++++--- .../tests/unit/controller/handlers/test_lbaas.py | 2 +- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/kuryr_kubernetes/controller/handlers/lbaas.py b/kuryr_kubernetes/controller/handlers/lbaas.py index 263ec3387..90278770b 100644 --- a/kuryr_kubernetes/controller/handlers/lbaas.py +++ b/kuryr_kubernetes/controller/handlers/lbaas.py @@ -50,9 +50,10 @@ class LBaaSSpecHandler(k8s_base.ResourceEventHandler): lbaas_spec = self._get_lbaas_spec(service) if self._should_ignore(service): - LOG.debug("Skiping Kubernetes service of an unsupported kind or " - "without a selector as Kubernetes does not create an " - "endpoint object for it.") + LOG.debug("Skipping Kubernetes service %s of an unsupported kind " + "or without a selector as Kubernetes does not create " + "an endpoint object for it.", + service['metadata']['name']) return if self._has_lbaas_spec_changes(service, lbaas_spec): @@ -242,6 +243,8 @@ class LoadBalancerHandler(k8s_base.ResourceEventHandler): def on_present(self, endpoints): lbaas_spec = self._get_lbaas_spec(endpoints) if self._should_ignore(endpoints, lbaas_spec): + LOG.debug("Ignoring Kubernetes endpoints %s", + endpoints['metadata']['name']) return lbaas_state = self._get_lbaas_state(endpoints) diff --git a/kuryr_kubernetes/tests/unit/controller/handlers/test_lbaas.py b/kuryr_kubernetes/tests/unit/controller/handlers/test_lbaas.py index a5dc11dd2..80a97d290 100644 --- a/kuryr_kubernetes/tests/unit/controller/handlers/test_lbaas.py +++ b/kuryr_kubernetes/tests/unit/controller/handlers/test_lbaas.py @@ -90,7 +90,7 @@ class TestLBaaSSpecHandler(test_base.TestCase): m_handler._set_lbaas_spec.assert_not_called() def test_on_present_no_selector(self): - svc_event = mock.sentinel.svc_event + svc_event = {'metadata': {'name': 'dummy_name'}} old_spec = mock.sentinel.old_spec m_handler = mock.Mock(spec=h_lbaas.LBaaSSpecHandler)