openstack
/
masakari-dashboard
Code Issues Proposed changes

Update patch set 1 

Patch Set 1:

(1 comment)

Patch-set: 1
Attention: {"person_ident":"Gerrit User 30491 \u003c30491@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_29313\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 29313 \u003c29313@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_29313\u003e replied on the change"}
This commit is contained in:
Gerrit User 29313 2023-01-18 17:49:50 +00:00 committed by Gerrit Code Review
parent b5cf037bc3
commit 399ef023ef
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
9a8de719a23ae88eb9cb686cb99b97d913c40953
View File

@ -33,6 +33,24 @@
"message": "Now need to switch this to skip_install\u003dTrue to avoid future problems with installing unpinned requirements (as requirements.txt is not in deps).",
"revId": "9a8de719a23ae88eb9cb686cb99b97d913c40953",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "74abe183_db016243",
"filename": "tox.ini",
"patchSetId": 1
},
"lineNbr": 90,
"author": {
"id": 29313
},
"writtenOn": "2023-01-18T17:49:50Z",
"side": 1,
"message": "Can you provide some references on why should I use skip_insall\u003dTrue here?\n\nThe reason I pushed this patch is because of https://github.com/tox-dev/tox/issues/270",
"parentUuid": "e6271d4b_aebce4e1",
"revId": "9a8de719a23ae88eb9cb686cb99b97d913c40953",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}