openstack
/
metalsmith
Code Issues Proposed changes

Add unit tests for the recent IP display addition

This commit is contained in:
Dmitry Tantsur 2018-05-09 16:39:15 +02:00
parent 36859f37d8
commit 396b56a57a
1 changed files with 15 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
metalsmith/test/test_provisioner.py
View File

@ -105,7 +105,7 @@ class TestProvisionNode(Base):
def test_with_wait(self):
self.api.get_port.return_value = mock.Mock(
spec=['fixed_ips'],
fixed_ips=[{'ip': '192.168.1.5'}]
fixed_ips=[{'ip_address': '192.168.1.5'}, {}]
)
self.pr.provision_node(self.node, 'image', ['network'], wait=3600)
@ -135,6 +135,20 @@ class TestProvisionNode(Base):
self.assertFalse(self.api.release_node.called)
self.assertFalse(self.api.delete_port.called)
@mock.patch.object(_provisioner.LOG, 'warning', autospec=True)
def test_with_wait_no_ips(self, mock_warn):
self.api.get_port.return_value = mock.Mock(
spec=['fixed_ips'], fixed_ips=[]
)
self.pr.provision_node(self.node, 'image', ['network'], wait=3600)
self.api.node_action.assert_called_once_with(self.node, 'active',
configdrive=mock.ANY)
self.api.wait_for_node_state.assert_called_once_with(self.node,
'active',
timeout=3600)
mock_warn.assert_called_once_with('No IPs for node %s', mock.ANY)
def test_dry_run(self):
self.pr._dry_run = True
self.pr.provision_node(self.node, 'image', ['network'])