From 6c55e2f3e2ac39e540d162e6dfb20d8586d68ff3 Mon Sep 17 00:00:00 2001 From: Dmitry Tantsur Date: Tue, 22 Jan 2019 10:06:30 +0100 Subject: [PATCH] Properly mock configdrive building in unit tests Currently we fail unit tests if genisoimage is not present, e.g. in RDO. Change-Id: Id241c9625628de101e2ed40d71cb8d4ed06a50ed --- metalsmith/test/test_provisioner.py | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/metalsmith/test/test_provisioner.py b/metalsmith/test/test_provisioner.py index bc23e90..9b97632 100644 --- a/metalsmith/test/test_provisioner.py +++ b/metalsmith/test/test_provisioner.py @@ -268,6 +268,10 @@ class TestProvisionNode(Base): self.api.network.create_port.return_value.id ], } + self.configdrive_mock = self.useFixture( + fixtures.MockPatchObject(_config.InstanceConfig, + 'build_configdrive', autospec=True) + ).mock def test_ok(self): inst = self.pr.provision_node(self.node, 'image', @@ -283,6 +287,8 @@ class TestProvisionNode(Base): self.api.baremetal.update_node.assert_called_once_with( self.node, instance_info=self.instance_info, extra=self.extra) self.api.baremetal.validate_node.assert_called_once_with(self.node) + self.configdrive_mock.assert_called_once_with(mock.ANY, self.node, + self.node.name) self.api.baremetal.set_node_provision_state.assert_called_once_with( self.node, 'active', config_drive=mock.ANY) self.assertFalse(self.api.network.delete_port.called) @@ -371,6 +377,8 @@ class TestProvisionNode(Base): self.api.baremetal.update_node.assert_called_once_with( self.node, instance_info=self.instance_info, extra=self.extra) self.api.baremetal.validate_node.assert_called_once_with(self.node) + self.configdrive_mock.assert_called_once_with(mock.ANY, self.node, + hostname) self.api.baremetal.set_node_provision_state.assert_called_once_with( self.node, 'active', config_drive=mock.ANY) self.assertFalse(