openstack
/
metalsmith
Code Issues Proposed changes

Update patch set 7 

Patch Set 7: Code-Review+2

(3 comments)

Patch-set: 7
Reviewer: Gerrit User 10239 <10239@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=+2, 365f4e30a525ad46a8e38f4166b7a87582afd669
This commit is contained in:
Gerrit User 10239 2024-04-18 06:34:56 +00:00 committed by Gerrit Code Review
parent 045cd49973
commit 9d54aba11c
1 changed files with 55 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

55
7f42d1cadf57edf1d7f5c2ee6a2aa87820a809a3 Normal file
View File

@ -0,0 +1,55 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "0c8f5892_bd27615f",
"filename": "playbooks/integration/centos8-image.yaml",
"patchSetId": 7
},
"lineNbr": 17,
"author": {
"id": 10239
},
"writtenOn": "2024-04-18T06:34:56Z",
"side": 1,
"message": "nit: ideally, we shouldn\u0027t make this file zuul-specific",
"revId": "7f42d1cadf57edf1d7f5c2ee6a2aa87820a809a3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "5bfe3a8f_79e6415c",
"filename": "playbooks/integration/centos8-image.yaml",
"patchSetId": 7
},
"lineNbr": 33,
"author": {
"id": 10239
},
"writtenOn": "2024-04-18T06:34:56Z",
"side": 1,
"message": "nit: You add -x in centos9 version",
"revId": "7f42d1cadf57edf1d7f5c2ee6a2aa87820a809a3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "a0a349c9_b372cc45",
"filename": "playbooks/integration/centos9-image.yaml",
"patchSetId": 7
},
"lineNbr": 17,
"author": {
"id": 10239
},
"writtenOn": "2024-04-18T06:34:56Z",
"side": 1,
"message": "same",
"revId": "7f42d1cadf57edf1d7f5c2ee6a2aa87820a809a3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}