Add a CentOS job with legacy local boot

When netboot is removed from Ironic, we need a job to cover local boot
in legacy mode. The new job will do it.

Also drop "local" from the job name, it's the default.

Change-Id: I6cad4556d770a733245d12f9a211e8ff7a3d884b

.zuul.yaml

@@ -96,6 +96,7 @@
         GLANCE_LIMIT_IMAGE_SIZE_TOTAL: 5000
         IRONIC_BAREMETAL_BASIC_OPS: true
         IRONIC_BUILD_DEPLOY_RAMDISK: false
+        IRONIC_BOOT_MODE: uefi
         IRONIC_DEFAULT_DEPLOY_INTERFACE: direct
         IRONIC_DEPLOY_DRIVER: ipmi
         IRONIC_RAMDISK_TYPE: tinyipa
@@ -117,7 +118,7 @@
       metalsmith_python: python3
 
 - job:
-    name: metalsmith-integration-glance-localboot-centos8-uefi
+    name: metalsmith-integration-glance-centos8-uefi
     description: |
         Integration job using Glance as image source and CentOS8 with local boot
         and UEFI. Images are built with diskimage-builder.
@@ -144,6 +145,19 @@
       metalsmith_swap_size: 1024
       metalsmith_traits: [CUSTOM_GOLD]
 
+# Remove when no longer used by other projects
+- job:
+    name: metalsmith-integration-glance-localboot-centos8-uefi
+    parent: metalsmith-integration-glance-centos8-uefi
+
+- job:
+    name: metalsmith-integration-glance-centos8-legacy
+    parent: metalsmith-integration-glance-centos8-uefi
+    vars:
+      devstack_localrc:
+        IRONIC_BOOT_MODE: bios
+      metalsmith_boot_mode: bios
+
 - job:
     name: metalsmith-integration-glance-netboot-cirros
     description: |
@@ -178,11 +192,13 @@
       - release-notes-jobs-python3
     check:
       jobs:
-        - metalsmith-integration-glance-localboot-centos8-uefi
+        - metalsmith-integration-glance-centos8-uefi
+        - metalsmith-integration-glance-centos8-legacy
         - metalsmith-integration-glance-netboot-cirros
         - metalsmith-integration-http-netboot-cirros
     gate:
       jobs:
-        - metalsmith-integration-glance-localboot-centos8-uefi
+        - metalsmith-integration-glance-centos8-uefi
+        - metalsmith-integration-glance-centos8-legacy
         - metalsmith-integration-glance-netboot-cirros
         - metalsmith-integration-http-netboot-cirros

playbooks/integration/centos8-image.yaml

@@ -23,8 +23,15 @@
   shell: chmod 0644 /boot/vmlinuz-*
   become: true
 
+- name: Detect the right block device element
+  set_fact:
+    centos_block_device: block-device-efi
+  when: metalsmith_boot_mode | default('uefi') != 'bios'
+
 - name: Build a centos8 wholedisk image
-  command: disk-image-create centos grub2 vm block-device-efi -o centos8-wholedisk
+  command: >
+    disk-image-create centos grub2 vm {{ centos_block_device | default('') }}
+    -o centos8-wholedisk
   environment:
     DIB_RELEASE: 8-stream