From 710253232f8d6da6d84e4164af9e83590a51456a Mon Sep 17 00:00:00 2001 From: Joseph Davis Date: Thu, 3 Jan 2019 11:15:35 -0800 Subject: [PATCH] Improve error message when plugin detection fails. The previous message didn't give much detail, which has led to some confusion and questions from users. This change attempts to add some more detail and help in debugging why a plugin detection might fail. Story: 2004696 Task: 28712 Change-Id: Ifc0a1bca747f655765aaa23b23751b52d4586133 --- monasca_setup/main.py | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/monasca_setup/main.py b/monasca_setup/main.py index 68bb8906..9a7ec15d 100644 --- a/monasca_setup/main.py +++ b/monasca_setup/main.py @@ -469,8 +469,12 @@ def plugin_detection( plugin_config.merge(new_config) elif not skip_failed: LOG.warning("Failed detection of plugin %s." - "\n\tPossible causes: Service not found or missing" - "arguments.", detect.name) + "\n\tPossible causes: Service not found or missing arguments. " + "\n\tFor services, the service is required to be running at " + "detection time. For other plugins, check the args (paths, " + "urls, etc)." + "\n\tDetection may also fail if monasca-agent services " + "(statsd, forwarder, collector) are not running.", detect.name) return None return plugin_config