openstack
/
monasca-api
Code Issues Proposed changes

Set legacy_kafka_client_enabled = False on default 

We change the default value of kafka.legacy_kafka_client_enabled from
True to False. The use of new Confluent Kafka client is recommended.

DevStack plugin does not set this option anymore.

Depends-On: https://review.opendev.org/740959
Depends-On: https://review.opendev.org/740966
Change-Id: I4d57b8893a6a131769009dc3299789d3fc89bab6
Story: 2007924
Task: 40338
This commit is contained in:
Witek Bedyk 2020-07-14 15:13:22 +02:00
parent 9b79bf633b
commit 3014c840d6
5 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
devstack/lib/notification.sh
View File

@ -92,7 +92,6 @@ configure_monasca-notification() {
fi
iniset "${MONASCA_NOTIFICATION_CONF}" kafka url ${SERVICE_HOST}:9092
iniset "${MONASCA_NOTIFICATION_CONF}" kafka legacy_kafka_client_enabled false
iniset "${MONASCA_NOTIFICATION_CONF}" database repo_driver ${dbDriver}
iniset "${MONASCA_NOTIFICATION_CONF}" email_notifier grafana_url ${SERVICE_HOST}:3000
iniset "${MONASCA_NOTIFICATION_CONF}" keystone auth_url ${SERVICE_HOST}/identity/v3

1
devstack/lib/persister.sh
View File

@ -172,7 +172,6 @@ configure_monasca_persister_python() {
iniset $MONASCA_PERSISTER_CONF DEFAULT debug $ENABLE_DEBUG_LOG_LEVEL
iniset "$MONASCA_PERSISTER_CONF" kafka num_processors 1
iniset "$MONASCA_PERSISTER_CONF" kafka legacy_kafka_client_enabled false
iniset "$MONASCA_PERSISTER_CONF" kafka_metrics uri $SERVICE_HOST:9092
iniset "$MONASCA_PERSISTER_CONF" kafka_metrics group_id 1_metrics

1
devstack/plugin.sh
View File

@ -851,7 +851,6 @@ function configure_monasca_api_python {
# messaging
iniset "$MONASCA_API_CONF" messaging driver "monasca_api.common.messaging.kafka_publisher:KafkaPublisher"
iniset "$MONASCA_API_CONF" kafka uri "$SERVICE_HOST:9092"
iniset "$MONASCA_API_CONF" kafka legacy_kafka_client_enabled false
# databases
iniset "$MONASCA_API_CONF" database connection $dbAlarmUrl

2
monasca_api/conf/kafka.py
View File

@ -59,7 +59,7 @@ kafka_opts = [
cfg.BoolOpt('drop_data', default=False,
help='Specify if received data should be simply dropped. '
'This parameter is only for testing purposes. (NOT USED)'),
cfg.BoolOpt(name='legacy_kafka_client_enabled', default=True,
cfg.BoolOpt(name='legacy_kafka_client_enabled', default=False,
required=True, advanced=True,
help='Enable legacy Kafka client. When set old version of '
'kafka-python library is used. Message format version '

6
releasenotes/notes/disable-legacy-kafka-client-16dd1ac1894fe7a0.yaml Normal file
View File

@ -0,0 +1,6 @@
---
upgrade:
- |
The default value of ``kafka.legacy_kafka_client_enabled`` has changed
from ``True`` to ``False``. The use of new Confluent Kafka client is
recommended.