openstack
/
monasca-specs
Code Issues Proposed changes

Update patch set 9 

Patch Set 9:

(2 comments)

Patch-set: 9
This commit is contained in:
Gerrit User 11580 2018-08-03 19:13:03 +00:00 committed by Gerrit Code Review
parent c95f0ff0b1
commit 46c8b60774
1 changed files with 42 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

42
69d06bb96e9d6a2da0074c5766a6d13da585200e
View File

@ -53,6 +53,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3f79a3b5_5a613539",
"filename": "specs/rocky/approved/monasca-events-publishing.rst",
"patchSetId": 9
},
"lineNbr": 0,
"author": {
"id": 11580
},
"writtenOn": "2018-08-03T19:13:03Z",
"side": 1,
"message": "Thx! Monasca Events API doesnt have querying capability yet, I will add paragraph about cross tenant monitoring in the spec since its important.",
"parentUuid": "5f7c97a3_9db6d58c",
"revId": "69d06bb96e9d6a2da0074c5766a6d13da585200e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5f7c97a3_c8d7c8bc",
@ -547,6 +565,30 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3f79a3b5_ba4ba9ae",
"filename": "specs/rocky/approved/monasca-events-publishing.rst",
"patchSetId": 9
},
"lineNbr": 403,
"author": {
"id": 11580
},
"writtenOn": "2018-08-03T19:13:03Z",
"side": 1,
"message": "I agree \"hostname\" is important. Lets add this back in again. We can leverage ability to define \"trait\" via a config file to always \"hostname\".\n\nRegarding \"service\", do you think we should add a mapping file, something that maps event name to a service and maintain such a file?",
"parentUuid": "5f7c97a3_3836afe1",
"range": {
"startLine": 402,
"startChar": 3,
"endLine": 403,
"endChar": 45
},
"revId": "69d06bb96e9d6a2da0074c5766a6d13da585200e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5f7c97a3_1e4f3a69",