From 410115088ef774bed38db9f2b88931d103e30359 Mon Sep 17 00:00:00 2001 From: sajuptpm Date: Wed, 25 Jul 2018 16:41:46 +0530 Subject: [PATCH] Enable mutable config in monasca_transform New releases of oslo.config support a 'mutable' parameter to Opts. oslo.service provides an option here Icec3e664f3fe72614e373b2938e8dee53cf8bc5e allows services to tell oslo.service they want mutate_config_files to be called by passing a parameter. This commit is to use the same. This allows monasca_transform to benefit from I1e7a69de169cc85f4c09954b2f46ce2da7106d90, where the 'debug' option (owned by oslo.log) is made mutable. we should be able to turn debug logging on and off by changing the config. tc goal: https://governance.openstack.org/tc/goals/rocky/enable-mutable-configuration.html Change-Id: I86571df78014a810ffa881ceceeddfc5193c9ca5 --- monasca_transform/service/transform_service.py | 2 +- tests/unit/service/test_transform_service.py | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/monasca_transform/service/transform_service.py b/monasca_transform/service/transform_service.py index 02d0491..c9dbc7a 100644 --- a/monasca_transform/service/transform_service.py +++ b/monasca_transform/service/transform_service.py @@ -288,7 +288,7 @@ def main_service(): """Method to use with Openstack service.""" ConfigInitializer.basic_config() LogUtils.init_logger(__name__) - launcher = os_service.ServiceLauncher(cfg.CONF) + launcher = os_service.ServiceLauncher(cfg.CONF, restart_method='mutate') launcher.launch_service(Transform()) launcher.wait() diff --git a/tests/unit/service/test_transform_service.py b/tests/unit/service/test_transform_service.py index 27f5a47..6ee200b 100644 --- a/tests/unit/service/test_transform_service.py +++ b/tests/unit/service/test_transform_service.py @@ -53,7 +53,8 @@ class TransformServiceTestBase(unittest.TestCase): launcher = oslo_service.service.launch( self.conf, transform_service.Transform(), - workers=1) + workers=1, + restart_method='mutate') status = launcher.wait() except SystemExit as exc: traceback.print_exc()