From 7a5c61342ed731a1c2f4e0232b3e8216d6b3cd31 Mon Sep 17 00:00:00 2001
From: Rob Raymond <rob.raymond@hp.com>
Date: Wed, 8 Oct 2014 10:53:19 -0600
Subject: [PATCH] Move expression field to angularjas so that fields line up
 better.

Change-Id: Idd5ba503e74090c75492bb879fb2c3f473d35cd2
---
 monitoring/alarmdefs/forms.py                 | 57 ++++---------------
 .../templates/alarmdefs/_create.html          |  7 ++-
 .../templates/alarmdefs/expression_field.html | 16 ++++--
 .../static/monitoring/js/controllers.js       |  6 +-
 4 files changed, 33 insertions(+), 53 deletions(-)

diff --git a/monitoring/alarmdefs/forms.py b/monitoring/alarmdefs/forms.py
index 343f2b4c..a1641f64 100644
--- a/monitoring/alarmdefs/forms.py
+++ b/monitoring/alarmdefs/forms.py
@@ -15,12 +15,13 @@
 # under the License.
 
 import re
+import json
 
 from django import forms as django_forms
 from django.template.loader import get_template
 from django.template import Context
 from django.utils import html
-from django.utils.translation import ugettext_lazy as _  # noqa
+from django.utils.translation import ugettext as _  # noqa
 
 from horizon import exceptions
 from horizon import forms
@@ -31,57 +32,24 @@ from monitoring.alarmdefs import constants
 
 
 class ExpressionWidget(forms.Widget):
-    def __init__(self, initial, attrs):
+    def __init__(self, initial, attrs=None):
         super(ExpressionWidget, self).__init__(attrs)
         self.initial = initial
 
     def render(self, name, value, attrs):
         final_attrs = self.build_attrs(attrs, name=name)
         t = get_template(constants.TEMPLATE_PREFIX + 'expression_field.html')
-        local_attrs = {'service': ''}
+        func = json.dumps([('min', _('min')), ('max', _('max')), ('sum', _('sum')),
+        ('count', _('count')), ('avg', _('avg'))])
+        comparators = [['>', '>'], ['>=', '>='], ['<', '<'], ['<=', '<=']]
+
+
+        local_attrs = {'service': '', 'func': func, 'comparators': comparators}
         local_attrs.update(final_attrs)
         context = Context(local_attrs)
         return t.render(context)
 
 
-
-class SimpleExpressionWidget(django_forms.MultiWidget):
-    def __init__(self, initial, attrs=None):
-        comparators = [('>', '>'), ('>=', '>='), ('<', '<'), ('<=', '<=')]
-        func = [('min', _('min')), ('max', _('max')), ('sum', _('sum')),
-                ('count', _('count')), ('avg', _('avg'))]
-        _widgets = (
-            django_forms.widgets.Select(attrs=attrs, choices=func),
-            ExpressionWidget(initial, attrs={}),
-            django_forms.widgets.Select(attrs=attrs, choices=comparators),
-            django_forms.widgets.TextInput(),
-        )
-        super(SimpleExpressionWidget, self).__init__(_widgets, attrs)
-
-    def decompress(self, expr):
-        if expr:
-            return re.search('^(\w+)\((.*)\) ([<>=]*) (.*)$', expr).groups()
-        else:
-            return [None, None, None, None]
-
-    def format_output(self, rendered_widgets):
-        return ''.join(rendered_widgets)
-
-    def value_from_datadict(self, data, files, name):
-        values = [
-            widget.value_from_datadict(data, files, name + '_%s' % i)
-            for i, widget in enumerate(self.widgets)]
-        try:
-            expression = '%s(%s) %s %s' % (values[0],
-                                           values[1],
-                                           values[2],
-                                           values[3])
-        except ValueError:
-            return ''
-        else:
-            return expression
-
-
 class NotificationField(forms.MultiValueField):
     def __init__(self, *args, **kwargs):
         super(NotificationField, self).__init__(*args, **kwargs)
@@ -166,13 +134,12 @@ class BaseAlarmForm(forms.SelfHandlingForm):
     def _init_fields(self, readOnly=False, create=False, initial=None):
         required = True
         textWidget = None
-        textAreaWidget = forms.Textarea(attrs={'class': 'large-text-area'})
         choiceWidget = forms.Select
         if create:
-            expressionWidget = SimpleExpressionWidget(initial)
+            expressionWidget = ExpressionWidget(initial)
             notificationWidget = NotificationCreateWidget()
         else:
-            expressionWidget = textAreaWidget
+            expressionWidget = textWidget
             notificationWidget = NotificationCreateWidget()
 
         self.fields['name'] = forms.CharField(label=_("Name"),
@@ -184,7 +151,7 @@ class BaseAlarmForm(forms.SelfHandlingForm):
                                                     widget=expressionWidget)
         self.fields['description'] = forms.CharField(label=_("Description"),
                                                      required=False,
-                                                     widget=textAreaWidget)
+                                                     widget=textWidget)
         sev_choices = [("LOW", _("Low")),
                        ("MEDIUM", _("Medium")),
                        ("HIGH", _("High")),
diff --git a/monitoring/alarmdefs/templates/alarmdefs/_create.html b/monitoring/alarmdefs/templates/alarmdefs/_create.html
index da1b1674..c6c4494b 100644
--- a/monitoring/alarmdefs/templates/alarmdefs/_create.html
+++ b/monitoring/alarmdefs/templates/alarmdefs/_create.html
@@ -43,18 +43,19 @@ $('#notification_table').on('click', '#remove_notif_button', (function(event){
 metricsList = {{ metrics | safe }}
 </script>
 <style>
-  #id_expression_0 {
+  #function {
       width: auto;
       float: left;
   }
   #metric-chooser {
       width: auto;
+      float: left;
   }
-  #id_expression_2 {
+  #comparators {
       width: auto;
       float: left;
   }
-  #id_expression_3 {
+  #threshold {
       width: auto;
   }
  </style>
diff --git a/monitoring/alarmdefs/templates/alarmdefs/expression_field.html b/monitoring/alarmdefs/templates/alarmdefs/expression_field.html
index 5dfdd3a2..a34e0162 100644
--- a/monitoring/alarmdefs/templates/alarmdefs/expression_field.html
+++ b/monitoring/alarmdefs/templates/alarmdefs/expression_field.html
@@ -1,10 +1,18 @@
 {% load i18n %}
 <div ng-controller="alarmEditController" ng-init="init('{{ service }}')">
     <input type="hidden" name="{{ name }}" id="dimension"/>
-    <select id="metric-chooser" class="form-control"
-            ng-model="currentMetric"
-            ng-options="metric for metric in metricNames"
-            ng-change="metricChanged()"></select>
+    <div style="margin-bottom:5px;">
+        <select id="function" class="form-control"
+                ng-model="currentFunction" ng-options="f[0] as f[1] for f in {{func}}"></select>
+        <select id="metric-chooser" class="form-control"
+                ng-model="currentMetric"
+                ng-options="metric for metric in metricNames"
+                ng-change="metricChanged()">
+                </select>
+        <select id="comparators" class="form-control"
+                ng-model="currentComparator" ng-options="f[0] as f[1] for f in {{comparators}}"></select>
+        <input type="number" id="threshold" class="form-control" ng-model="currentThreshold"/>
+    </div>
     <tags-input id="dimension-chooser" ng-model="tags"
                 placeholder="{% trans 'Add a dimension' %}"
                 add-from-autocomplete-only="true"
diff --git a/monitoring/static/monitoring/js/controllers.js b/monitoring/static/monitoring/js/controllers.js
index 8a29a7b8..f40f46f2 100644
--- a/monitoring/static/monitoring/js/controllers.js
+++ b/monitoring/static/monitoring/js/controllers.js
@@ -34,6 +34,10 @@ angular.module('monitoring.controllers', [])
         $scope.metrics = metricsList;
         $scope.metricNames = uniqueNames(metricsList, 'name')
         $scope.currentMetric = $scope.metricNames[0];
+        $scope.currentFunction = "max";
+        $scope.currentComparator = ">";
+        $scope.currentThreshold = 0;
+        $scope.tags = [];
         $scope.possibleDimensions = function(query) {
             var deferred = $q.defer();
             var dim = {}
@@ -90,7 +94,7 @@ angular.module('monitoring.controllers', [])
                 }
                 dim += value['text']
             })
-            return $scope.currentMetric + '{' + dim + '}';
+            return $scope.currentMetric + '{' + dim + '} ' + $scope.currentComparator + ' ' + $scope.currentThreshold;
         }
         $scope.init = function(defaultTag) {
             if (defaultTag.length > 0) {