openstack
/
murano-dashboard
Code Issues Proposed changes

Merge "Show all form-level validation errors, not only one."

This commit is contained in:
Jenkins 2013-09-11 08:42:39 +00:00 committed by Gerrit Code Review
parent dd85dd0e1b 46e4344843
commit a5cd8369a5
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
muranodashboard/panel/services/forms.py
View File

@ -244,11 +244,13 @@ class ServiceConfigurationForm(UpdatableFieldsForm):
cleaned_data = super(ServiceConfigurationForm, self).clean()
all_data = self.service.update_cleaned_data(self, cleaned_data)
context = yaql.create_context()
error_messages = []
for validator in self.validators:
expr = self.get_yaql_expr(validator['expr'])
if not yaql.parse(expr).evaluate(all_data, context):
raise forms.ValidationError(
_(validator.get('message', '')))
error_messages.append(_(validator.get('message', '')))
if error_messages:
raise forms.ValidationError(error_messages)
for name, field in self.fields.iteritems():
if isinstance(field, fields.PasswordField):