From ecb019b58b62d3fbc510506a35e38bdd1f8336fe Mon Sep 17 00:00:00 2001 From: zhurong Date: Sun, 9 Jul 2017 16:08:30 +0800 Subject: [PATCH] Fix create environment TypeError Now create environment give the error: TypeError: get_form() takes exactly 2 arguments (1 given) This patch fix this. Change-Id: I4833b9c13249d547a91f13094b5764f788014dfb Closes-Bug: #1703174 --- muranodashboard/environments/views.py | 3 ++- muranodashboard/tests/unit/environments/test_views.py | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/muranodashboard/environments/views.py b/muranodashboard/environments/views.py index d3921a1c9..39fb7e0e1 100644 --- a/muranodashboard/environments/views.py +++ b/muranodashboard/environments/views.py @@ -174,9 +174,10 @@ class CreateEnvironmentView(views.ModalFormView): submit_url = reverse_lazy( 'horizon:app-catalog:environments:create_environment') - def get_form(self, form_class): + def get_form(self, **kwargs): if 'next' in self.request.GET: self.request.session['next_url'] = self.request.GET['next'] + form_class = kwargs.get('form_class', self.get_form_class()) return super(CreateEnvironmentView, self).get_form(form_class) def get_success_url(self): diff --git a/muranodashboard/tests/unit/environments/test_views.py b/muranodashboard/tests/unit/environments/test_views.py index f2539b8db..1aa077ef1 100644 --- a/muranodashboard/tests/unit/environments/test_views.py +++ b/muranodashboard/tests/unit/environments/test_views.py @@ -271,7 +271,7 @@ class TestCreateEnvironmentView(testtools.TestCase): @mock.patch('muranodashboard.environments.forms.net') def test_get_form(self, mock_net): mock_net.get_available_networks.return_value = None - form = self.create_env_view.get_form(self.create_env_view.form_class) + form = self.create_env_view.get_form() self.assertIsInstance(form, env_forms.CreateEnvironmentForm) self.assertEqual('next_foo_url',