openstack
/
murano
Code Issues Proposed changes

Merge "Increase unit test coverage for hacking checks"

This commit is contained in:
Jenkins 2016-10-03 18:53:19 +00:00 committed by Gerrit Code Review
parent 132b3c0cbb a3a053d9ba
commit 7d9eecff4d
1 changed files with 39 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

39
murano/tests/unit/test_hacking.py
View File

@ -96,3 +96,42 @@ class HackingTestCase(base.MuranoTestCase):
self.assertEqual(0, len(list(checks.no_mutable_default_args(
"defined, undefined = [], {}"))))
def test_check_python3_no_iteritems(self):
self.assertEqual(1, len(list(checks.check_python3_no_iteritems(
"{'foo': 'bar'}.iteritems()"))))
self.assertEqual(0, len(list(checks.check_python3_no_iteritems(
"six.iteritems({'foo': 'bar'}"))))
def test_check_python3_no_iterkeys(self):
self.assertEqual(1, len(list(checks.check_python3_no_iterkeys(
"{'foo': 'bar'}.iterkeys()"))))
self.assertEqual(0, len(list(checks.check_python3_no_iterkeys(
"six.iterkeys({'foo': 'bar'}"))))
def test_check_python3_no_itervalues(self):
self.assertEqual(1, len(list(checks.check_python3_no_itervalues(
"{'foo': 'bar'}.itervalues()"))))
self.assertEqual(0, len(list(checks.check_python3_no_itervalues(
"six.itervalues({'foo': 'bar'}"))))
def test_check_no_basestring(self):
self.assertEqual(1, len(list(checks.check_no_basestring(
"isinstance('foo', basestring)"))))
self.assertEqual(0, len(list(checks.check_no_basestring(
"isinstance('foo', six.string_types)"))))
def test_factory(self):
mock_register = mock.MagicMock()
checks.factory(mock_register)
expected = [
mock.call(checks.no_mutable_default_args),
mock.call(checks.check_python3_no_iteritems),
mock.call(checks.check_python3_no_iterkeys),
mock.call(checks.check_python3_no_itervalues),
mock.call(checks.check_no_basestring)]
mock_register.assert_has_calls(expected)