From f0bc9476beae5658c4039846ac9fb5c63dfc2360 Mon Sep 17 00:00:00 2001 From: David Moreau-Simard Date: Fri, 25 Nov 2016 14:10:02 -0500 Subject: [PATCH] Reduce the amount of smoke tests from 61 to 40 Smoke testing is designed around a compromise in testing quality in order to have results in a way that consumes less resources and time. We want to be able to have a reasonable confidence that the service works fairly well without having to run too many tests. As such, let's keep what still amounts to a fairly good testing of each component tagged as smoke. More in-depth testing can still be achieved with the right pattern matching but smoke testing will not be as lengthy and resource consuming now. Change-Id: I1544fe8d0b4548e6c078310b08fc83af2c10b211 --- .../tests/api/application_catalog/test_categories.py | 2 -- .../tests/api/application_catalog/test_env_templates.py | 6 ------ .../tests/api/application_catalog/test_environments.py | 4 ---- .../tests/api/application_catalog/test_repository.py | 4 ---- .../tests/api/application_catalog/test_services.py | 3 --- .../tests/api/application_catalog/test_sessions.py | 1 - .../tests/api/application_catalog/test_static_actions.py | 1 - 7 files changed, 21 deletions(-) diff --git a/murano_tempest_tests/tests/api/application_catalog/test_categories.py b/murano_tempest_tests/tests/api/application_catalog/test_categories.py index 16ef91bcf..68059367b 100644 --- a/murano_tempest_tests/tests/api/application_catalog/test_categories.py +++ b/murano_tempest_tests/tests/api/application_catalog/test_categories.py @@ -58,14 +58,12 @@ class TestCategories(base.BaseApplicationCatalogIsolatedAdminTest): categories_list = self.application_catalog_client.list_categories() self.assertNotIn(name, categories_list) - @testtools.testcase.attr('smoke') def test_get_category(self): category = self.application_catalog_client.get_category( self.category['id']) self.assertEqual(self.category['id'], category['id']) self.assertEqual(self.category['name'], category['name']) - @testtools.testcase.attr('smoke') def test_add_package_to_new_category_and_remove_it_from_category(self): category = self.application_catalog_client.get_category( self.category['id']) diff --git a/murano_tempest_tests/tests/api/application_catalog/test_env_templates.py b/murano_tempest_tests/tests/api/application_catalog/test_env_templates.py index 6d57afc34..7b250ac98 100644 --- a/murano_tempest_tests/tests/api/application_catalog/test_env_templates.py +++ b/murano_tempest_tests/tests/api/application_catalog/test_env_templates.py @@ -21,7 +21,6 @@ from murano_tempest_tests import utils class TestEnvironmentTemplatesSanity(base.BaseApplicationCatalogTest): - @testtools.testcase.attr('smoke') def test_list_empty_env_templates(self): templates_list = self.application_catalog_client.\ get_env_templates_list() @@ -61,13 +60,11 @@ class TestEnvironmentTemplates(base.BaseApplicationCatalogTest): delete_env_template(cls.env_template['id']) super(TestEnvironmentTemplates, cls).resource_cleanup() - @testtools.testcase.attr('smoke') def test_get_env_template(self): env_template = self.application_catalog_client.\ get_env_template(self.env_template['id']) self.assertEqual(self.env_template['name'], env_template['name']) - @testtools.testcase.attr('smoke') def test_create_env_template_with_a_service(self): name = utils.generate_name('create_env_template_with_service') post_body = self._get_demo_app() @@ -115,7 +112,6 @@ class TestEnvironmentTemplates(base.BaseApplicationCatalogTest): post_body) self.assertEqual("updated_name", service['name']) - @testtools.testcase.attr('smoke') def test_create_public_env_template(self): name = utils.generate_name('create_public_env_template') env_template = self.application_catalog_client.\ @@ -127,7 +123,6 @@ class TestEnvironmentTemplates(base.BaseApplicationCatalogTest): get_env_template(env_template['id']) self.assertTrue(env_temp['is_public']) - @testtools.testcase.attr('smoke') def test_clone_env_template(self): name = utils.generate_name('clone_env_template') cloned_template = self.alt_client.\ @@ -138,7 +133,6 @@ class TestEnvironmentTemplates(base.BaseApplicationCatalogTest): template = self.alt_client.get_env_template(cloned_template['id']) self.assertEqual(name, template['name']) - @testtools.testcase.attr('smoke') def test_get_public_private_both_env_templates(self): name = utils.generate_name('get_public_private_both') public_env_template = self.application_catalog_client.\ diff --git a/murano_tempest_tests/tests/api/application_catalog/test_environments.py b/murano_tempest_tests/tests/api/application_catalog/test_environments.py index ed649b01f..051fc001f 100644 --- a/murano_tempest_tests/tests/api/application_catalog/test_environments.py +++ b/murano_tempest_tests/tests/api/application_catalog/test_environments.py @@ -56,7 +56,6 @@ class TestEnvironments(base.BaseApplicationCatalogTest): self.assertEqual(len(environments_list), len(upd_environments_list)) - @testtools.testcase.attr('smoke') def test_create_and_delete_environment_with_unicode_name(self): environments_list = self.application_catalog_client.\ get_environments_list() @@ -73,7 +72,6 @@ class TestEnvironments(base.BaseApplicationCatalogTest): self.assertEqual(len(environments_list), len(upd_environments_list)) - @testtools.testcase.attr('smoke') def test_get_environment(self): environment = self.application_catalog_client.\ get_environment(self.environment['id']) @@ -85,7 +83,6 @@ class TestEnvironments(base.BaseApplicationCatalogTest): update_environment(self.environment['id']) self.assertIsNot(self.environment['name'], environment['name']) - @testtools.testcase.attr('smoke') def test_get_environment_model(self): model = self.application_catalog_client.\ get_environment_model(self.environment['id']) @@ -100,7 +97,6 @@ class TestEnvironments(base.BaseApplicationCatalogTest): self.assertEqual("{0}-network".format(self.environment['name']), net_name) - @testtools.testcase.attr('smoke') def test_update_environment_model(self): session = self.application_catalog_client. \ create_session(self.environment['id']) diff --git a/murano_tempest_tests/tests/api/application_catalog/test_repository.py b/murano_tempest_tests/tests/api/application_catalog/test_repository.py index 75e9fb77b..8d23604fd 100644 --- a/murano_tempest_tests/tests/api/application_catalog/test_repository.py +++ b/murano_tempest_tests/tests/api/application_catalog/test_repository.py @@ -78,7 +78,6 @@ class TestRepository(base.BaseApplicationCatalogIsolatedAdminTest): cls.application_catalog_client.delete_package(cls.package['id']) super(TestRepository, cls).resource_cleanup() - @testtools.testcase.attr('smoke') def test_get_package(self): package = self.application_catalog_client.get_package( self.package['id']) @@ -171,14 +170,11 @@ class TestRepository(base.BaseApplicationCatalogIsolatedAdminTest): self.package['id'], post_body) self.assertEqual("New name", result['name']) - @testtools.testcase.attr('smoke') def test_download_package(self): self.application_catalog_client.download_package(self.package['id']) - @testtools.testcase.attr('smoke') def test_get_ui_definitions(self): self.application_catalog_client.get_ui_definition(self.package['id']) - @testtools.testcase.attr('smoke') def test_get_logo(self): self.application_catalog_client.get_logo(self.package['id']) diff --git a/murano_tempest_tests/tests/api/application_catalog/test_services.py b/murano_tempest_tests/tests/api/application_catalog/test_services.py index 37b384ad4..53ab70b77 100644 --- a/murano_tempest_tests/tests/api/application_catalog/test_services.py +++ b/murano_tempest_tests/tests/api/application_catalog/test_services.py @@ -78,7 +78,6 @@ class TestServices(base.BaseApplicationCatalogTest): get_services_list(self.environment['id'], session['id']) self.assertEqual(1, len(services_list)) - @testtools.testcase.attr('smoke') def test_clear_services_via_put(self): session = self.application_catalog_client.\ create_session(self.environment['id']) @@ -103,7 +102,6 @@ class TestServices(base.BaseApplicationCatalogTest): get_services_list(self.environment['id'], session['id']) self.assertEqual(1, len(services_list_)) - @testtools.testcase.attr('smoke') def test_get_service(self): session = self.application_catalog_client.\ create_session(self.environment['id']) @@ -123,7 +121,6 @@ class TestServices(base.BaseApplicationCatalogTest): session['id']) self.assertEqual(service, service_) - @testtools.testcase.attr('smoke') def test_get_services_without_sess_id(self): services = self.application_catalog_client.\ get_services_list(self.environment['id'], None) diff --git a/murano_tempest_tests/tests/api/application_catalog/test_sessions.py b/murano_tempest_tests/tests/api/application_catalog/test_sessions.py index e36ccd0db..e19f44598 100644 --- a/murano_tempest_tests/tests/api/application_catalog/test_sessions.py +++ b/murano_tempest_tests/tests/api/application_catalog/test_sessions.py @@ -48,7 +48,6 @@ class TestSessions(base.BaseApplicationCatalogTest): self.application_catalog_client.delete_session(self.environment['id'], session['id']) - @testtools.testcase.attr('smoke') def test_get_session(self): session = self.application_catalog_client.\ create_session(self.environment['id']) diff --git a/murano_tempest_tests/tests/api/application_catalog/test_static_actions.py b/murano_tempest_tests/tests/api/application_catalog/test_static_actions.py index 480b0c45b..3d337c200 100644 --- a/murano_tempest_tests/tests/api/application_catalog/test_static_actions.py +++ b/murano_tempest_tests/tests/api/application_catalog/test_static_actions.py @@ -52,7 +52,6 @@ class TestStaticActions(base.BaseApplicationCatalogTest): client.delete_package(cls.package['id']) super(TestStaticActions, cls).resource_cleanup() - @testtools.testcase.attr('smoke') def test_call_static_action_basic(self): action_result = self.application_catalog_client.call_static_action( class_name=self.package['class_definitions'][0],