openstack
/
murano
Code Issues Proposed changes

Increase unit test coverage for Version Negotiation API. 

Implements bp: murano-unit-test-coverage

Change-Id: I3ab653fae79c2bf2660e57199aeab44b2684f1d8
This commit is contained in:
Felipe Monteiro 2016-10-18 17:40:22 -04:00
parent d2ea832a2f
commit f2b0db77d4
1 changed files with 66 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

70
murano/tests/unit/api/middleware/test_version_negotiation.py
View File

@ -13,19 +13,81 @@
# License for the specific language governing permissions and limitations
# under the License.
import mock
import webob
from murano.api import versions
from murano.api.middleware import version_negotiation
from murano.api import versions
from murano.tests.unit import base
class MiddlewareVersionNegotiationTest(base.MuranoTestCase):
def test_middleware_version_negotiation_default(self):
@mock.patch.object(version_negotiation, 'LOG')
def test_middleware_version_negotiation_default(self, mock_log):
middleware_vn = version_negotiation.VersionNegotiationFilter(None)
request = webob.Request.blank('/environments')
result = middleware_vn.process_request(request)
self.assertIsInstance(result, versions.Controller)
mock_log.warning.assert_called_once_with(
version_negotiation._LW(
"Unknown version. Returning version choices."))
@mock.patch.object(version_negotiation, 'LOG')
def test_process_request(self, mock_log):
"""Test process_request using different valid paths."""
middleware_vn = version_negotiation.VersionNegotiationFilter(None)
for path in ('v1', '/v1', '///v1'):
request = webob.Request.blank(path)
request.method = 'GET'
request.environ = {}
result = middleware_vn.process_request(request)
self.assertIsNone(result)
self.assertIn('api.version', request.environ)
self.assertEqual(1, request.environ['api.version'])
self.assertEqual('/v1', request.path_info)
mock_log.debug.assert_any_call(
"Matched version: v{version}".format(version=1))
mock_log.debug.assert_any_call(
'new path {path}'.format(path='/v1'))
request = webob.Request.blank('/v1/')
request.method = 'GET'
request.environ = {}
result = middleware_vn.process_request(request)
self.assertIsNone(result)
self.assertIn('api.version', request.environ)
self.assertEqual(1, request.environ['api.version'])
self.assertEqual('/v1/', request.path_info)
mock_log.debug.assert_any_call(
"Matched version: v{version}".format(version=1))
mock_log.debug.assert_any_call(
'new path {path}'.format(path='/v1/'))
@mock.patch.object(version_negotiation, 'LOG')
def test_process_request_without_path(self, mock_log):
middleware_vn = version_negotiation.VersionNegotiationFilter(None)
request = webob.Request.blank('')
request.method = 'GET'
request.environ = {}
result = middleware_vn.process_request(request)
self.assertIsInstance(result, versions.Controller)
mock_log.warning.assert_called_once_with(
version_negotiation._LW(
"Unknown version. Returning version choices."))
def test_factory(self):
app = version_negotiation.VersionNegotiationFilter.factory(None)
self.assertIsNotNone(app)
self.assertEqual(
version_negotiation.VersionNegotiationFilter, type(app(None)))