openstack
/
neutron-fwaas
Code Issues Proposed changes

notify the plugin only on status updated 

If the status of the firewall group is consistent with the status
to be updated, there is no need to notify the plugin to update the
status.
The processing of the agent requires a certain amount of time. If
firewall group is updated during this period, updating the firewall
group status at this time may cause the firewall group to be in an
incorrect state.

Partial-Bug: #2021457

Change-Id: I316827259367d78d7dbb57888ad41408d44c43f6
This commit is contained in:
zhouhenglc 2023-05-26 11:10:07 +08:00
parent e479c1a1d6
commit 72ad4f96db
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
neutron_fwaas/services/firewall/service_drivers/agents/l3reference/firewall_l3_agent_v2.py
View File

@ -232,10 +232,10 @@ class FWaaSL3AgentExtension(l3_extension.L3AgentExtension):
LOG.exception(msg, {'status': firewall_group['status'],
'fwg_id': firewall_group['id']})
status = nl_constants.ERROR
# Notify the plugin of firewall group's status.
self.fwplugin_rpc.set_firewall_group_status(
ctx, firewall_group['id'], status)
if firewall_group['status'] != status:
# Notify the plugin of firewall group's status.
self.fwplugin_rpc.set_firewall_group_status(
ctx, firewall_group['id'], status)
def _process_router_update(self, updated_router):
"""If a new or existing router in the local namespace is updated,