openstack
/
neutron-fwaas
Code Issues Proposed changes

test_dhcp_agent: Fix no-op tests 

Fix some uses of assertCalledOnceWith, which seems like a mistake of
assert_called_once_with.

Also, add a hacking check to prevent the mistake.

Closes-Bug: #1397184
Change-Id: I12d077e2724d52eff65d55aff1130fbbb69671b1
This commit is contained in:
YAMAMOTO Takashi 2014-11-28 14:33:47 +09:00
parent f006590d9f
commit f745b12bb4
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
HACKING.rst
View File

@ -13,7 +13,7 @@ Neutron Specific Commandments
- [N321] Validate that jsonutils module is used instead of json
- [N322] We do not use @authors tags in source files. We have git to track
authorship.
- [N323] assert_called_once() is not a valid method
- [N323] Detect common errors with assert_called_once_with
Creating Unit Tests
-------------------