Remove LABEL from API definitions

LABEL is now useless and plays no role that ALIAS can play

For this reason and since it can be a source of confusion for
people writing API definition files ("what the hell is this used for ?
what am I supposed to put here ?"), this change removes it.

The only places where this remains are https://bit.ly/2Gha5Xw (codesearch).
Cleaning up in these places is handled by the commits
which this change is depending on.

Depends-On: Ida395d94ed5b54ef9c42dc19cf099aab54fd0bb5
Depends-On: I4f0f94ce8d526bf6e1012823409582d46402625b
Depends-On: I96876caaba1e2663eb0451335327cb1276420d4f

Change-Id: I7e2502f8591ad664d20e23e58f33291575f29083

neutron_lib/api/definitions/_dummy.py

@@ -19,10 +19,6 @@
 # The alias of the extension.
 ALIAS = 'dummy'
 
-# The label to lookup the plugin in the plugin directory. It can match the
-# alias, as required.
-LABEL = 'DUMMY'
-
 # Whether or not this extension is simply signaling behavior to the user
 # or it actively modifies the attribute map (mandatory).
 IS_SHIM_EXTENSION = False

neutron_lib/api/definitions/address_scope.py

@@ -23,7 +23,6 @@ IPV4_ADDRESS_SCOPE = 'ipv4_%s' % ADDRESS_SCOPE
 IPV6_ADDRESS_SCOPE = 'ipv6_%s' % ADDRESS_SCOPE
 
 ALIAS = 'address-scope'
-LABEL = ALIAS
 IS_SHIM_EXTENSION = False
 IS_STANDARD_ATTR_EXTENSION = False
 NAME = 'Address scope'

neutron_lib/api/definitions/agent.py

@@ -17,7 +17,6 @@ from neutron_lib.api import converters
 from neutron_lib.db import constants
 
 ALIAS = 'agent'
-LABEL = ALIAS
 IS_SHIM_EXTENSION = False
 IS_STANDARD_ATTR_EXTENSION = False
 NAME = ALIAS

neutron_lib/api/definitions/allowedaddresspairs.py

@@ -24,7 +24,6 @@ validators.add_validator('allowed_address_pairs',
 
 ADDRESS_PAIRS = 'allowed_address_pairs'
 ALIAS = 'allowed-address-pairs'
-LABEL = ALIAS
 IS_SHIM_EXTENSION = False
 IS_STANDARD_ATTR_EXTENSION = False
 NAME = 'Allowed Address Pairs'

neutron_lib/api/definitions/auto_allocated_topology.py

@@ -20,7 +20,6 @@ from neutron_lib.api.definitions import l3
 from neutron_lib.api.definitions import network
 
 ALIAS = 'auto-allocated-topology'
-LABEL = ALIAS
 IS_SHIM_EXTENSION = False
 IS_STANDARD_ATTR_EXTENSION = False
 NAME = 'Auto Allocated Topology Services'

neutron_lib/api/definitions/bgpvpn.py

@@ -38,7 +38,6 @@ RTRD_REGEX = (r'^(%s:%s|%s:%s|%s:%s)$') % (UINT16_REGEX, UINT32_REGEX,
 
 # The alias of the extension.
 ALIAS = 'bgpvpn'
-LABEL = 'BGPVPN'
 
 # Whether or not this extension is simply signaling behavior to the user
 # or it actively modifies the attribute map.

neutron_lib/api/definitions/bgpvpn_routes_control.py

@@ -20,10 +20,6 @@ from neutron_lib.db import constants as db_const
 # The alias of the extension.
 ALIAS = 'bgpvpn-routes-control'
 
-# The label to lookup the plugin in the plugin directory. It can match the
-# alias, as required.
-LABEL = ALIAS
-
 # Whether or not this extension is simply signaling behavior to the user
 # or it actively modifies the attribute map (mandatory).
 IS_SHIM_EXTENSION = False

neutron_lib/api/definitions/bgpvpn_vni.py

@@ -24,10 +24,6 @@ VNI = 'vni'
 # The alias of the extension.
 ALIAS = 'bgpvpn-vni'
 
-# The label to lookup the plugin in the plugin directory. It can match the
-# alias, as required.
-LABEL = ALIAS
-
 # Whether or not this extension is simply signaling behavior to the user
 # or it actively modifies the attribute map.
 IS_SHIM_EXTENSION = False

neutron_lib/api/definitions/dhcpagentscheduler.py

@@ -24,7 +24,6 @@ DHCP_AGENT = 'dhcp-agent'
 DHCP_AGENTS = DHCP_AGENT + 's'
 
 ALIAS = constants.DHCP_AGENT_SCHEDULER_EXT_ALIAS
-LABEL = ''
 IS_SHIM_EXTENSION = False
 IS_STANDARD_ATTR_EXTENSION = False
 NAME = 'DHCP Agent Scheduler'

neutron_lib/api/definitions/dvr.py

@@ -19,7 +19,6 @@ from neutron_lib import constants
 DISTRIBUTED = 'distributed'
 
 ALIAS = constants.L3_DISTRIBUTED_EXT_ALIAS
-LABEL = ALIAS
 IS_SHIM_EXTENSION = False
 IS_STANDARD_ATTR_EXTENSION = False
 NAME = 'Distributed Virtual Router'

neutron_lib/api/definitions/extra_dhcp_opt.py

@@ -50,10 +50,6 @@ DHCP_OPT_CLIENT_ID = "client-id"
 # The alias of the extension.
 ALIAS = 'extra_dhcp_opt'
 
-# The label to lookup the plugin in the plugin directory. It can match the
-# alias, as required.
-LABEL = 'extra_dhcp_opt'
-
 # Whether or not this extension is simply signaling behavior to the user
 # or it actively modifies the attribute map (mandatory).
 IS_SHIM_EXTENSION = False

neutron_lib/api/definitions/l3.py

@@ -18,10 +18,6 @@ from neutron_lib.db import constants
 # The alias of the extension.
 ALIAS = 'router'
 
-# The label to lookup the plugin in the plugin directory. It can match the
-# alias, as required.
-LABEL = 'router'
-
 # Whether or not this extension is simply signaling behavior to the user
 # or it actively modifies the attribute map.
 IS_SHIM_EXTENSION = False

neutron_lib/api/definitions/network_mtu.py

@@ -20,10 +20,6 @@ MTU = 'mtu'
 # The alias of the extension.
 ALIAS = 'net-mtu'
 
-# The label to lookup the plugin in the plugin directory. It can match the
-# alias, as required.
-LABEL = ALIAS
-
 # Whether or not this extension is simply signaling behavior to the user
 # or it actively modifies the attribute map.
 IS_SHIM_EXTENSION = False

neutron_lib/api/definitions/network_mtu_writable.py

@@ -22,10 +22,6 @@ MTU = 'mtu'
 # The alias of the extension.
 ALIAS = 'net-mtu-writable'
 
-# The label to lookup the plugin in the plugin directory. It can match the
-# alias, as required.
-LABEL = ALIAS
-
 # Whether or not this extension is simply signaling behavior to the user
 # or it actively modifies the attribute map.
 IS_SHIM_EXTENSION = False

neutron_lib/api/definitions/port_security.py

@@ -25,10 +25,6 @@ PORTSECURITY = 'port_security_enabled'
 # The alias of the extension.
 ALIAS = 'port-security'
 
-# The label to lookup the plugin in the plugin directory. It can match the
-# alias, as required.
-LABEL = 'port-security'
-
 # Whether or not this extension is simply signaling behavior to the user
 # or it actively modifies the attribute map.
 IS_SHIM_EXTENSION = False

neutron_lib/api/definitions/portbindings.py

@@ -120,10 +120,6 @@ VNIC_TYPES = [VNIC_NORMAL, VNIC_DIRECT, VNIC_MACVTAP, VNIC_BAREMETAL,
 # The alias of the extension.
 ALIAS = 'binding'
 
-# The label to lookup the plugin in the plugin directory. It can match the
-# alias, as required.
-LABEL = 'binding'
-
 # Whether or not this extension is simply signaling behavior to the user
 # or it actively modifies the attribute map.
 IS_SHIM_EXTENSION = False

neutron_lib/api/definitions/subnet_segmentid_writable.py

@@ -19,10 +19,6 @@ from neutron_lib.api.definitions import subnet
 # The alias of the extension.
 ALIAS = 'subnet-segmentid-writable'
 
-# The label to lookup the plugin in the plugin directory. It can match the
-# alias, as required.
-LABEL = ALIAS
-
 # Whether or not this extension is simply signaling behavior to the user
 # or it actively modifies the attribute map.
 IS_SHIM_EXTENSION = False

releasenotes/notes/remove_label-801d7a1b13f179fa.yaml

@@ -0,0 +1,5 @@
+---
+other:
+  - |
+    The ``LABEL`` variable, which was uselessly duplicating ``ALIAS``, has been
+    removed from API definition modules.