Update patch set 3

Patch Set 3: Code-Review+1

(3 comments)

Patch-set: 3
Reviewer: Gerrit User 8556 <8556@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=+1, 1ae3ba0d359a317acdf3553666d3fa2181a62039
Attention: {"person_ident":"Gerrit User 8556 \u003c8556@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_8556\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 8313 \u003c8313@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_8556\u003e replied on the change"}
This commit is contained in:
Gerrit User 8556 2024-03-27 17:44:42 +00:00 committed by Gerrit Code Review
parent d7b5f61195
commit 5dc1b1c277
3 changed files with 69 additions and 0 deletions

View File

@ -0,0 +1,21 @@
{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "828c93c0_ed106ca9",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 3
},
"lineNbr": 0,
"author": {
"id": 8556
},
"writtenOn": "2024-03-27T17:44:42Z",
"side": 1,
"message": "lgtm, template comment can be checked/done as a separate change",
"revId": "62153d538bdb1c2c984d63ee3ccd725a6d811b40",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}

View File

@ -22,6 +22,30 @@
},
"revId": "9e3f892ab0764bfebeb7d1bb4452df6acc2b2203",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "802f39be_aeebbf55",
"filename": ".zuul.yaml",
"patchSetId": 2
},
"lineNbr": 22,
"author": {
"id": 8556
},
"writtenOn": "2024-03-27T17:44:42Z",
"side": 1,
"message": "Done",
"parentUuid": "f79bc2d0_74907252",
"range": {
"startLine": 22,
"startChar": 34,
"endLine": 22,
"endChar": 39
},
"revId": "9e3f892ab0764bfebeb7d1bb4452df6acc2b2203",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}

View File

@ -47,6 +47,30 @@
"revId": "a527762a07499a0198dc41777399517f35c51367",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "c923ecf7_e855fe4e",
"filename": ".zuul.yaml",
"patchSetId": 1
},
"lineNbr": 22,
"author": {
"id": 8556
},
"writtenOn": "2024-03-27T17:44:42Z",
"side": 1,
"message": "we do have neuron as required-project in openstack-python3-jobs-neutron template used here. but you can think of removing job and see if template only still fail or not.\n\nhttps://github.com/openstack/openstack-zuul-jobs/blob/3dbb70af7cc0b9d09d4a9b67a70a0cceafea77ce/zuul.d/project-templates.yaml#L906",
"parentUuid": "3ea4393a_676433e4",
"range": {
"startLine": 11,
"startChar": 0,
"endLine": 22,
"endChar": 39
},
"revId": "a527762a07499a0198dc41777399517f35c51367",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {