From 6e40758925923c6618a59eeb6a8b36a53e8088fb Mon Sep 17 00:00:00 2001 From: elajkat Date: Tue, 16 Apr 2024 15:26:40 +0200 Subject: [PATCH] Remove shell parameter from the call of subprocess_popen Remove shell parameter from subprocess_popen, [1] removes shell reference in the above method in Neutron to fulfill bandit B604 requirement. [1]: https://review.opendev.org/c/openstack/neutron/+/915467 Change-Id: I6866f66e1ee74b28fbe28ec30c11126d00652c2d --- neutron_vpnaas/services/vpn/common/netns_wrapper.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/neutron_vpnaas/services/vpn/common/netns_wrapper.py b/neutron_vpnaas/services/vpn/common/netns_wrapper.py index 25a4f6877..49a4b7184 100644 --- a/neutron_vpnaas/services/vpn/common/netns_wrapper.py +++ b/neutron_vpnaas/services/vpn/common/netns_wrapper.py @@ -56,7 +56,7 @@ def execute(cmd): cmd = list(map(str, cmd)) LOG.debug("Running command: %s", cmd) env = os.environ.copy() - obj = utils.subprocess_popen(cmd, shell=False, + obj = utils.subprocess_popen(cmd, stdin=subprocess.PIPE, stdout=subprocess.PIPE, stderr=subprocess.PIPE,