openstack
/
neutron-vpnaas
Code Issues Proposed changes

Update patch set 2 

Patch Set 2:

(1 comment)

Patch-set: 2
CC: Gerrit User 31976 <31976@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Attention: {"person_ident":"Gerrit User 28619 \u003c28619@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_31976\u003e replied on the change"}
This commit is contained in:
Gerrit User 31976 2024-01-19 16:12:17 +00:00 committed by Gerrit Code Review
parent 78ed74cef9
commit 7f4927e811
1 changed files with 21 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
256464aea691f8b4957ba668a117963353f34e4c Normal file
View File

@ -0,0 +1,21 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "edda46a8_8ab91d3e",
"filename": "neutron_vpnaas/db/vpn/vpn_models.py",
"patchSetId": 2
},
"lineNbr": 108,
"author": {
"id": 31976
},
"writtenOn": "2024-01-19T16:12:17Z",
"side": 0,
"message": "I don\u0027t think removing it here is enough. Maybe there should be a DB migration too. And it should be removed from the API definition in neutron-lib (neutron_lib/api/definitions/vpn.py VPN_SUPPORTED_DPD_ACTIONS).",
"revId": "256464aea691f8b4957ba668a117963353f34e4c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}