From e85a725686b6829a27e4e61313085831b9fa7925 Mon Sep 17 00:00:00 2001 From: Gerrit User 32755 <32755@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Date: Mon, 18 Mar 2024 12:21:38 +0000 Subject: [PATCH] Update patch set 2 Patch Set 2: (1 comment) Patch-set: 2 Attention: {"person_ident":"Gerrit User 8313 \u003c8313@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_32755\u003e replied on the change"} --- 41cd075ebc90b33b584129002d1f16590df49244 | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/41cd075ebc90b33b584129002d1f16590df49244 b/41cd075ebc90b33b584129002d1f16590df49244 index 86946c884..cb83ce8a4 100644 --- a/41cd075ebc90b33b584129002d1f16590df49244 +++ b/41cd075ebc90b33b584129002d1f16590df49244 @@ -16,6 +16,24 @@ "message": "I would like an agreement on this with the team, I will bring this topic to the team or the drivers meeting", "revId": "41cd075ebc90b33b584129002d1f16590df49244", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": false, + "key": { + "uuid": "e50b9b75_8eae4d7c", + "filename": "/PATCHSET_LEVEL", + "patchSetId": 2 + }, + "lineNbr": 0, + "author": { + "id": 32755 + }, + "writtenOn": "2024-03-18T12:21:38Z", + "side": 1, + "message": "Awesome, thanks!\n\nIf I may gently point you to the ML thread on moderizing the Python stack: https://lists.openstack.org/archives/list/openstack-discuss@lists.openstack.org/thread/4V63CHMZ4GPC4IYN7JCJPVKHLZAHN5BL/\n\nHaving types in Python opens so many opportunities to catch nasty runtime bugs in CI via static analysis (e.g. https://mypy-lang.org/). See e.g. https://review.opendev.org/c/openstack/cinder/+/909689 where typing was actually added to find a particular bug.\n\nTypes also help new contributors as it lowers the bar to add your feature to an existing code base.", + "parentUuid": "77764ca8_8122edd6", + "revId": "41cd075ebc90b33b584129002d1f16590df49244", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" } ] } \ No newline at end of file