openstack
/
neutron
Code Issues Proposed changes

Merge "test_metadata_agent: don't check implementation details"

This commit is contained in:
Jenkins 2015-03-04 04:00:08 +00:00 committed by Gerrit Code Review
parent efee8b6e41 5c606875ac
commit 5d85b396dd
1 changed files with 0 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
neutron/tests/unit/test_metadata_agent.py
View File

@ -571,8 +571,6 @@ class TestUnixDomainMetadataProxy(base.BaseTestCase):
with mock.patch('os.makedirs') as makedirs:
isdir.return_value = False
agent.UnixDomainMetadataProxy(mock.Mock())
isdir.assert_called_once_with('/the')
makedirs.assert_called_once_with('/the', 0o755)
def test_init_exists(self):
@ -580,8 +578,6 @@ class TestUnixDomainMetadataProxy(base.BaseTestCase):
with mock.patch('os.unlink') as unlink:
isdir.return_value = True
agent.UnixDomainMetadataProxy(mock.Mock())
isdir.assert_called_once_with('/the')
unlink.assert_called_once_with('/the/path')
def test_init_exists_unlink_no_file(self):
@ -593,10 +589,7 @@ class TestUnixDomainMetadataProxy(base.BaseTestCase):
unlink.side_effect = OSError
agent.UnixDomainMetadataProxy(mock.Mock())
isdir.assert_called_once_with('/the')
unlink.assert_called_once_with('/the/path')
exists.assert_called_once_with('/the/path')
def test_init_exists_unlink_fails_file_still_exists(self):
with mock.patch('os.path.isdir') as isdir:
@ -608,10 +601,7 @@ class TestUnixDomainMetadataProxy(base.BaseTestCase):
with testtools.ExpectedException(OSError):
agent.UnixDomainMetadataProxy(mock.Mock())
isdir.assert_called_once_with('/the')
unlink.assert_called_once_with('/the/path')
exists.assert_called_once_with('/the/path')
def test_run(self):
with mock.patch.object(agent, 'MetadataProxyHandler') as handler:
@ -623,7 +613,6 @@ class TestUnixDomainMetadataProxy(base.BaseTestCase):
p = agent.UnixDomainMetadataProxy(self.cfg.CONF)
p.run()
isdir.assert_called_once_with('/the')
makedirs.assert_called_once_with('/the', 0o755)
server.assert_has_calls([
mock.call('neutron-metadata-agent'),