openstack
/
neutron
Code Issues Proposed changes

Correct arguments to logging function 

ofctl_arg_supported contains a bad call to LOG.debug in an exception
path.

    LOG.debug("...%s. Exception: %s", (full_args, e))

This throws "TypeError: not enough arguments for format string" and
should be:

    LOG.debug("...%s. Exception: %s", full_args, e)

(Found via pylint)

Change-Id: Ib14666f60b16584f225b1e0c4fed82ef7e941aac
Closes-Bug: #1403296
This commit is contained in:
Angus Lees 2014-12-17 15:07:28 +11:00
parent fffc6e4712
commit 79f89db7fe
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
neutron/cmd/sanity/checks.py
View File

@ -68,7 +68,7 @@ def ofctl_arg_supported(root_helper, cmd, **kwargs):
agent_utils.execute(full_args, root_helper=root_helper)
except RuntimeError as e:
LOG.debug("Exception while checking supported feature via "
"command %s. Exception: %s", (full_args, e))
"command %s. Exception: %s", full_args, e)
return False
except Exception:
LOG.exception(_LE("Unexpected exception while checking supported"